Eddiebot: Add new contributors to the README ๐Ÿ’ป

Created on 9 Aug 2020  ยท  36Comments  ยท  Source: EddieJaoudeCommunity/EddieBot

I think @AllanRegush, @Ruth-ikegah should be added to the list using the all contributors bot, since they created issues and contributed with code recently. I think @prajwal0024 and @garretcharp have made some commits as well so they can be added as well ๐Ÿ˜ƒ.

What do you think @eddiejaoude and everyone else on the list?

All 36 comments

Sure I agree, thanks @BOLT04

Yes I agree ๐Ÿ‘

I think people can add themselves - I am still learning all contributors bot.

@all-contributors please add @Ruth-ikegah for code and documentation
@all-contributors please add @AllanRegush for code and bug fixes
@all-contributors please add @prajwal0024 for
@all-contributors please add @garretcharp for code and refactoring
@all-contributors please add @webkhushboo for documentation
@all-contributors please add @HarshKapadia2 for refactoring
@all-contributors please add @morrme for fixing bugs
@all-contributors please add @eddiejaoude for creating bugs ๐Ÿ˜‚

Hopefully I have not missed anyone, if I have, please add them or ask them to add themselves ๐Ÿค“

@eddiejaoude

I could not determine your intention.

Basic usage: @all-contributors please add @someone for code, doc and infra

For other usages see the documentation

Oh ๐Ÿค” ... maybe only 1 person per comment

@all-contributors please add @Ruth-ikegah for code and documentation
@all-contributors please add @AllanRegush for code and maintenance
@all-contributors please add @garretcharp for code and maintenance
@all-contributors please add @webkhushboo for doc
@all-contributors please add @HarshKapadia2 for maintenance
@all-contributors please add @morrme for maintenance
@all-contributors please add @alrifay for review

@eddiejaoude

I could not determine your intention.

Basic usage: @all-contributors please add @someone for code, doc and infra

For other usages see the documentation

@all-contributors please add @Ruth-ikegah for code and documentation

@eddiejaoude

I've put up a pull request to add @Ruth-ikegah! :tada:

@all-contributors please add @AllanRegush for code and maintenance

@all-contributors please add @garretcharp for code and maintenance

@eddiejaoude

I've put up a pull request to add @AllanRegush! :tada:

@all-contributors please add @webkhushboo for doc

@eddiejaoude

I've put up a pull request to add @garretcharp! :tada:

@eddiejaoude

I've put up a pull request to add @webkhushboo! :tada:

@all-contributors please add @HarshKapadia2 for refactoring

@eddiejaoude

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@all-contributors please add @HarshKapadia2 for maintenance

@eddiejaoude

I've put up a pull request to add @HarshKapadia2! :tada:

@all-contributors please add @alrifay for review

@eddiejaoude

I've put up a pull request to add @alrifay! :tada:

Sorry for the spam ๐Ÿคฆโ€โ™‚๏ธ

Oops I raised them to fast and now they conflict ๐Ÿคฆโ€โ™‚๏ธ - ok I will fix tomorrow

I think I got left out ๐Ÿ˜ญ lol

oh sorry @morrme . I will make sure you get added ๐Ÿค“

@all-contributors please add @morrme for maintenance

@eddiejaoude

I've put up a pull request to add @morrme! :tada:

@all-contributors please add @eddiejaoude for maintenance

@eddiejaoude

I've put up a pull request to add @eddiejaoude! :tada:

@all-contributors please add @prajwal0024 for code

@eddiejaoude I think everyone on the issue description is added now, can we close this issue? Or do you think we can leave it open to add more people?

Thank you @BOLT04. I removed all-contributors plugin because it is now displayed by GitHub and always up to date.

Screenshot 2020-09-24 at 21 02 01

@eddiejaoude GitHub shows people who contributed with code only ๐Ÿ˜

that is true @alrifay, great spot ๐Ÿ˜ƒ. I think we can keep the bot for the other types of contributions, since reviewing and maintaining a repo is also time-consuming, and imo they count as contributions.

@eddiejaoude what do you think?

or who contribute with docs, I guess anything that can be in a commit and go via a PR?

We are collecting stats of all the events that happens, I think when we have badges for those contributions it will be more fun and easier to manage. With all-contributors it got out of date too quickly and easily - I think the idea is great, but it should be more automatic.

Currently we are storing the events....

Screenshot 2020-09-24 at 23 57 57

What do you both think?

I agree with @eddiejaoude that info got out of date with the bot. If currently, GitHub counts contributors for changes to code and docs (anything that goes in a PR), then we could add to that by having a GitHub action that takes care of the contributions by opening issues, making comments on issues (this would be the maintenance part I guess) and PR reviews.

Was this page helpful?
0 / 5 - 0 ratings