Easy-digital-downloads: 3.0: "More" button on Orders list-table page not working

[JJJ]

Bug Report

Expected behavior

When I click "More" I expect the drop-down to appear.

Actual behavior

When I click "More" nothing happens.

Steps to reproduce the behavior

1) Visit Admin > Downloads > Orders
2) Click "More"
3) See nothing...

Information (if a specific version is affected):

PHP Version: Any
EDD Version (or branch): 3.0
WordPress Version: Any

[JJJ]

I think this is related to some clean-up that happened as part of #7052.

[JJJ]

After the proposed PR, the "More" button & drop-down are restored.

[spencerfinnell]

Noticed this too.

I’m unsure about the duplication between add & edit. If it is indeed a problem, we probably need a new & separate script registered for the Orders & Refunds list-table pages. That will require re-splitting the Orders JavaScript, because right now that’s all that’s in orders/index.js.

@cklosowski mentioned possibly renaming the pretty confusing edd-admin-payments and edd-admin-orders script handles to something more appropriate based on where they need to be loaded. There are new in 3.0 so no compatibility issues changing them now.

Happy to help shuffle things around if needed.

[cklosowski]

I think this should do the trick @mintplugins we do have a small bug i'm going to log for Post Beta which is if you want to filter non-free items you have to use 0.00 instead of simply 0, as it likely equates to empty and therefore like the field wasn't filled out.

[mintplugins]

Replicated on release/3.0. The more button is now working on issue/7297.

However, the states do not appear to be refreshing if you change the country.

[cklosowski]

Ok we can fix that in a later issue.

On Tue, Aug 20, 2019, 08:07 Phil Johnston [e-mail] wrote:

Replicated on release/3.0. The more button is now working on issue/7297.

However, the states do not appear to be refreshing if you change the
country.

[image: Screen Shot 2019-08-20 at 11 05 38 AM]
https://user-images.githubusercontent.com/1638128/63359405-b002be00-c33a-11e9-8d10-c9e7f32768e4.png

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/easydigitaldownloads/easy-digital-downloads/issues/7297?email_source=notifications&email_token=AAKTMLAJ4UA3XPT5K6R7KPDQFQCDBA5CNFSM4HXFAUHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4WT2PY#issuecomment-523058495,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKTMLAKN6OLJBRE4JX4CFLQFQCDBANCNFSM4HXFAUHA
.

[cklosowski]

@mintplugins as far as the scope of the filters being exposed, would you consider this resolved? If so we can open a new issue for the updating of the States/regions by country.

[JJJ]

@cklosowski _I_ think it's fine to fix that in a separate issue, as it's likely related to the server-side AJAX and the selectors having changed over time.

[mintplugins]

Opened a separate issue for that here: #7382. Note that it requires this issue in order for the "more" button to operate.

[cklosowski]

@mintplugins mind going a head and either requesting any changes or approving the PR attached to this one?