Easy-digital-downloads: Different download bundle selection for bundle variants

[Qara-Penimah]

When creating a download that is a bundle it should be possible to change the downloads that are distributed with each "download bundle variant". This works hand in hand with issue: #2611.

[chriscct7]

Not sure what you mean by this

[Qara-Penimah]

Yes I must admit I was having problems wording this.

Here is a scenario:

1. I have 3 downloads D1, D2, D3
2. Each download has variable pricing set to Regular, Plus, Business
3. Each variant (one of the variable price options) is set to distribute a different file when purchased
4. I create a new download which is a bundle - B1
5. B1 has variable pricing with each option set to Regular, Plus, Business
6. I will distribute my initial 3 downloads D1, D2 & D3 above in this bundle
7. When the Regular bundle (B1.Regular) is bought I want to distribute D1.Regular, D2.regular & D3.Regular and when the Plus bundle (B1.Plus) is bought I want to distribute D1.Plus, D2.Plus & D3.Plus and so forth

Hope this helps

[Qara-Penimah]

To clarify this issue is to allow each download bundle option (variable price) to be able to distribute different downloads/download variant.

[pippinsplugins]

This has come up before and I would like to find a way to support it.

[Qara-Penimah]

Adding this feature would go a long way towards making the bundle feature complete. Let me know what support you need.

[SDavisMedia]

Bump! Here's a good reason to get this going:

It would be great if this stayed in 2.7. :+1:

[sunnyratilal]

Ready for some testing!

Merry Christmas! 🎅

[pippinsplugins]

@sunnyratilal I'm getting an undefined offset notice:

wp-content/plugins/easy-digital-downloads/includes/admin/downloads/metabox.php:561

[pippinsplugins]

Also the display is wrong.

Notice how the dropdown has the price options available but there is also a Price Assignment dropdown? That dropdown shouldn't be there.

[SDavisMedia]

@sunnyratilal you're a saint!

@pippinsplugins If the bundle itself is variable pricing (like the scenario here), wouldn't the Price Assignment column be used for that? That way you can tie child download price options to a price assignment of the bundle itself. Here's my config:

Seems to be working well on my end:

[pippinsplugins]

Oh! I didn't think of it that way. @SDavisMedia you're right.

We do have an issue, though. The price assignment drop down shows on bundles that do not use variable prices.

[SDavisMedia]

@sunnyratilal I am also getting the aforementioned error if I don't set things up properly/in the right oder. Same issue as Pippin here: https://github.com/easydigitaldownloads/easy-digital-downloads/issues/2612#issuecomment-269225534

@pippinsplugins (and Sunny) I'm having issues with the price assignment dropdown too. Particularly _when_ it decides to reveal itself. It seems to me that the entire Price Assignment _column_ in the Download Files metabox should depend directly on the Enable variable pricing setting in the Download Price metabox... only revealing itself if the bundle is variable pricing.

[pippinsplugins]

It seems to me that the entire Price Assignment column in the Download Files metabox should depend directly on the Enable variable pricing setting in the Download Price metabox... only revealing itself if the bundle is variable pricing.

I agree.

[sunnyratilal]

@pippinsplugins @SDavisMedia Ready for another test.

[SDavisMedia]

@sunnyratilal The UI is looking great. Can't find any visual/behavioral quirks at the moment.

I am having a problem using the All selection for a product added to the bundle, though. Here's an example configuration:

No matter which bundle price option I purchase, I should also get "Basic Download," its files, and a license key for it. On the purchase receipt I get the license for it but nothing else:

Purchase record does not include the Basic Download product as being purchased but it does show that the license was generated with that purchase:

---

Payment meta if you need it:

_edd_payment_user_id => 1
_edd_payment_meta=> array(8) {
  ["key"]=>
  string(32) "f24ec97055eedbc363cab214554acf67"
  ["email"]=>
  string(20) "[email protected]"
  ["date"]=>
  string(0) ""
  ["user_info"]=>
  array(5) {
    ["id"]=>
    int(1)
    ["email"]=>
    string(20) "[email protected]"
    ["first_name"]=>
    string(4) "Sean"
    ["last_name"]=>
    string(5) "Davis"
    ["discount"]=>
    string(4) "none"
  }
  ["downloads"]=>
  array(1) {
    [0]=>
    array(3) {
      ["id"]=>
      int(1387)
      ["quantity"]=>
      int(1)
      ["options"]=>
      array(2) {
        ["quantity"]=>
        int(1)
        ["price_id"]=>
        string(1) "1"
      }
    }
  }
  ["cart_details"]=>
  array(1) {
    [0]=>
    array(10) {
      ["name"]=>
      string(21) "Issue 2612 Bundle One"
      ["id"]=>
      int(1387)
      ["item_number"]=>
      array(3) {
        ["id"]=>
        int(1387)
        ["quantity"]=>
        int(1)
        ["options"]=>
        array(2) {
          ["quantity"]=>
          int(1)
          ["price_id"]=>
          string(1) "1"
        }
      }
      ["item_price"]=>
      float(50)
      ["quantity"]=>
      int(1)
      ["discount"]=>
      float(0)
      ["subtotal"]=>
      float(50)
      ["tax"]=>
      float(0)
      ["fees"]=>
      array(0) {
      }
      ["price"]=>
      float(50)
    }
  }
  ["fees"]=>
  array(0) {
  }
  ["currency"]=>
  string(3) "USD"
}
_edd_payment_gateway => manual
_edd_payment_user_email => [email protected]
_edd_payment_user_ip => ::1
_edd_payment_purchase_key => f24ec97055eedbc363cab214554acf67
_edd_payment_mode => live
_edd_payment_customer_id => 2
_edd_payment_total => 50
_edd_payment_tax => 0
_edd_completed_date => 2016-12-29 10:28:16

[sunnyratilal]

@SDavisMedia The purchase record is correct - only the bundle should be displayed. It's a bug in the method that retrieves the files for the purchase. I thought I already addressed the issue but I'll investigate.

[sunnyratilal]

@SDavisMedia Fixed - ready for another test.

[SDavisMedia]

The purchase record is correct - only the bundle should be displayed.

Oops! I knew that. I swear I'm an idiot sometimes lol.

All working on my end. I really like the UI and as of now, I cannot break it. Thumbs up from me. :+1:

[pippinsplugins]

Price Assignment is showing improperly for me on a bundle that does _not_ have variable prices enabled.

[pippinsplugins]

[pippinsplugins]

If I toggle variable pricing on and off, the Price Assignment column goes away as expected, so it's just on first load.

[sunnyratilal]

@pippinsplugins Fixed in 561cdd1ac36c9ec6cb0d215a063164683764e904

[sunnyratilal]

@pippinsplugins @SDavisMedia Could I get one more round of testing here please?

[SDavisMedia]

@sunnyratilal I left an inline comment on the latest commit.

I was not never able to replicate what @pippinsplugins experienced above, and it's still working properly for me after a few more tests.

So after the correction for the last commit, this is a thumbs up from me. :+1:

[pippinsplugins]

@cklosowski mind reviewing as well please?

[pippinsplugins]

UI is working properly for me now.

[cklosowski]

@pippinsplugins it's on my list. I'll get it now.

[cklosowski]

This isn't saving correcly on the first creation of the prices. When I initially created it (before hitting save) I created 3 variable prices, and added 3 different price IDs from a product to it, and the price assignments seemed to not save correcly on the first save...after clicking publish/save, all things saved correctly.

We've seen this behavior before, and it's usually due to something in the chosen library not resetting the indexes. I'll try and replicate it again, but might be worth a look to see if you can replicate in creating an entire product in a single page load.

[sunnyratilal]

@cklosowski Just replicated it - I'll see if I can debug it and fix.

[cklosowski]

Getting some errors here now:

( ! ) Notice: Undefined variable: price_key in /Users/cklosowski/Development/edd.dev/wp-content/plugins/easy-digital-downloads/includes/admin/downloads/metabox.php on line 604

( ! ) Notice: Undefined variable: price_key in /Users/cklosowski/Development/edd.dev/wp-content/plugins/easy-digital-downloads/includes/admin/downloads/metabox.php on line 608

[sunnyratilal]

@cklosowski Fixed in 6a37d33ff4ffe98aea063e79915c92cad560b37e

[cklosowski]

@sunnyratilal Something still not quite right here.

First setup, before hitting 'Publish/Save'

After hitting 'Update/Save':

[sunnyratilal]

Replicated the bug - it's saving correctly initially. Verified in wp_postmeta. It's to do with the logic when displaying the Price Assignments.

[sunnyratilal]

@cklosowski should be fixed now

[cklosowski]

Backend UI is looking good. Front end seems to be bumping the delivered items by 1:

Backend:

Frontend after purchase:

[sunnyratilal]

@SDavisMedia and @cklosowski have both tested and said everything works as expected.

[sunnyratilal]

Merged!

[sunnyratilal]

Merged!

[pippinsplugins]

This is triggering some undefined notices on purchase confirmation.

Undefined variable: bundle_item_id

wp-content/plugins/easy-digital-downloads/templates/shortcode-receipt.php:184

Undefined variable: bundle_price_id

wp-content/plugins/easy-digital-downloads/templates/shortcode-receipt.php:184

That happened when purchasing a bundle and a non-bundle at the same time.

[sunnyratilal]

Fixed in d6d55317edb5454f2b147e894f8e5223d00d58c9