Easy-digital-downloads: Remove PDF Earnings Export

[pippinsplugins]

Currently the PDF export only supports the current year.

We need to add support for start / end year and start / end month.

[thefrosty]

I've been contacted by a client looking to get this done. I'll keep this thread updated as I work with the pending client.

[pippinsplugins]

:+1:

[evertiro]

I have the beginnings of this working but something occurred to me... couldn't this be done better by rewriting to use the EDD_Stats class?

[pippinsplugins]

Yes it could
On Aug 1, 2014 11:21 PM, "Ghost1227" [email protected] wrote:

I have the beginnings of this working but something occurred to me...
couldn't this be done better by rewriting to use the EDD_Stats class?

—
Reply to this email directly or view it on GitHub
https://github.com/easydigitaldownloads/Easy-Digital-Downloads/issues/1808#issuecomment-50953517
.

[evertiro]

Then let's switch it!

[pippinsplugins]

I'm tagging this as mayble later because it's possible we will remove the PDF exports entirely and replace them with better CSV exports.

[evertiro]

Oh?

[pippinsplugins]

The PDF libraries are enormous and painful. We can build much better reports with plain CSVs.

[evertiro]

Does that mean removing the PDF libraries entirely from core?

[pippinsplugins]

Yes, though we will obviously do that carefully so as not to affect PDF
stamper.

On Tuesday, August 12, 2014, Ghost1227 [email protected] wrote:

Does that mean removing the PDF libraries entirely from core?

—
Reply to this email directly or view it on GitHub
https://github.com/easydigitaldownloads/Easy-Digital-Downloads/issues/1808#issuecomment-51913188
.

[evertiro]

You just made my day :)

[chriscct7]

I feel we should do a user survey. As much as it may make sense for us because the libraries are "large", I'm wondering if there's alot of people using them. I really feel we should do a poll, maybe 2 questions:

1. Do you use the current PDF reports
2. Would you prefer better CSV reports than PDF reports

[pippinsplugins]

@chriscct7 Not PDF Invoices, PDF Reports. They are different.

[chriscct7]

Sorry, thats what I meant

[evertiro]

What about simply splitting PDF Reports into a plugin?

[pippinsplugins]

Yes, we should definitely do a survey.

On Tue, Aug 12, 2014 at 8:38 AM, Chris Christoff [email protected]
wrote:

Sorry, thats what I meant

—
Reply to this email directly or view it on GitHub
https://github.com/easydigitaldownloads/Easy-Digital-Downloads/issues/1808#issuecomment-51914513
.

[pippinsplugins]

That'd be a good idea. Anyone want to volunteer?

On Tue, Aug 12, 2014 at 8:39 AM, Ghost1227 [email protected] wrote:

What about simply splitting PDF Reports into a plugin?

—
Reply to this email directly or view it on GitHub
https://github.com/easydigitaldownloads/Easy-Digital-Downloads/issues/1808#issuecomment-51914600
.

[evertiro]

Think I already did... though kinda dreading it.

[pippinsplugins]

All yours buddy :D

On Tue, Aug 12, 2014 at 8:41 AM, Ghost1227 [email protected] wrote:

Think I already did... though kinda dreading it.

—
Reply to this email directly or view it on GitHub
https://github.com/easydigitaldownloads/Easy-Digital-Downloads/issues/1808#issuecomment-51914893
.

[cklosowski]

@pippinsplugins @ghost1227 where do we stand with this? Now that we have a batch exporter build, are we still looking at supporting the PDFs?

[pippinsplugins]

I would still like to remove all PDF exports. They are far too large and provide very little benefit.

Replacing them with comprehensive CSV reports sounds like a much better method to me. See #3055

[pippinsplugins]

Let's remove it and release a free plugin with the feature.

[pippinsplugins]

We will need to update PDF Invoices with version checks and file_exists checks to PDF libraries.

[chriscct7]

As #3055 was punted to 2.6, this needs to be punted to at least 2.6

[pippinsplugins]

:+1:

[pippinsplugins]

PR submitted!

Now we need to get PDF Invoices updated. @sunnyratilal could you take care of that next week so that it conditionally loads the fpdf library if it's not available in core?

[pippinsplugins]

@ghost1227 also need to confirm that everything is fine here with PDF Stamper.

[evertiro]

@pippinsplugins PDF Stamper no longer references any PDF functionality from core, but I'll double check...

[chriscct7]

FES also need stop be checked but I think we've been bundling our own
library as well

On Aug 12, 2016 1:21 PM, "Ghost1227" [email protected] wrote:

@pippinsplugins https://github.com/pippinsplugins PDF Stamper no longer
references any PDF functionality from core, but I'll double check...

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/easydigitaldownloads/easy-digital-downloads/issues/1808#issuecomment-239506825,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABQ2XUgQhhxd224vJZ7PFlK_rV0shBAHks5qfKuAgaJpZM4BVGQU
.

[sunnyratilal]

PDF Invoices uses tcpdf which is already included in the plugin. Upgraded from fpdf to TCPDF back when 2.0 was released so removing this from Core won't affect PDF Invoices at all.

[sunnyratilal]

@pippinsplugins googlechartlib also can be removed from includes/libraries as it was only used for the PDF reports and isn't used anywhere else in Core.

[pippinsplugins]

@sunnyratilal nice, thanks.

@chriscct7 FES includes its own copy of fPDF but it does load googlechartlib from core:

/**
 * Make PDF chart.
 *
 * Creates chart used in FES pdf.
 *
 * @since 2.3.0
 * @access public
 *
 * @param FES_Vendor $vendor Vendor to make PDF for.
 * @return GoogleChart Chart to put on pdf.
 */
function fes_draw_chart_image( $vendor ) {
    require_once EDD_PLUGIN_DIR . '/includes/libraries/googlechartlib/GoogleChart.php';
    require_once EDD_PLUGIN_DIR . '/includes/libraries/googlechartlib/markers/GoogleChartShapeMarker.php';
    require_once EDD_PLUGIN_DIR . '/includes/libraries/googlechartlib/markers/GoogleChartTextMarker.php';
.....

Let's move those to FES and get an update pushed out asap. @chriscct7

[pippinsplugins]

I'm going to go ahead and merge this into release/2.7 so that we can more easily identify issues in the coming months.

[pippinsplugins]

PR submitted to remove them from FES too.

[cklosowski]

Ok from what i'm seeing, we're good on all the dependencies @pippinsplugins @ghost1227 @sunnyratilal @chriscct7 correct? If so then I think we can make sure this is closed out properly, once and for all with 2.7.

[evertiro]

No problems on my end!

[pippinsplugins]

Yep. FES has been updated already.

[sunnyratilal]

Yep all ready for merge in 2.7

[pippinsplugins]

Merged into release/2.7 already.