Easy-digital-downloads: Adjust purchase form total based on Item Quantity
This is a $50 product:
Would be nice if the price updated with the item quantity entry. Very similar to how Custom Prices works.
SDavisMedia
All 15 comments
:+1: like this idea. We'll easily be able to account for our base templates and our themes, i think that's a fair set of compatibility. Themes that customize the purchase link without keeping our classes in tact might not see the change, but that should be a graceful degradation.
cklosowski
on 11 Apr 2017
Ok @SDavisMedia this is ready for some testing. I used Vendd and Twenty Seventeen to test it out. Some formats to test:
1) USD with Before as currency position
2) USD with After as currency position
3) JPY (since it's a zero-decimal currency)
4) Change thousands and decimal separators.
cklosowski
on 19 May 2017
Oh, one more thing, I fixed up the Markup to use a few spans around the currency symbol as well as the amount so I could target them specifically for changes, but in doing so I realized that we didn't respect the currency position option in our purchase link buttons...so I fixed that up as well.
cklosowski
on 19 May 2017
@cklosowski notes from meeting
- purchase button flashes the new HTML
- the dash between price and purchase text also needs to be wrapped in a span
SDavisMedia
on 23 May 2017
@SDavisMedia updated to have a span on the separator...I'm not seeing this flash of the HTML, can you show me on your end with a quick .gif or something?
cklosowski
on 7 Jun 2017
@cklosowski Can you wrap the add to cart text too please? The goal is to have no free floating text as siblings to markup.
One sec on the flashing markup.
SDavisMedia
on 7 Jun 2017
Video: http://quick.as/b2vghz5ga
SDavisMedia
on 7 Jun 2017
@SDavisMedia that should fix it up for you, all its have spans and classes once again :)
cklosowski
on 8 Jun 2017
@cklosowski golden!!! 馃檶
SDavisMedia
on 8 Jun 2017
I've tested Twenty Seventeen. Will test Sixteen and our themes before merging. @SDavisMedia @pippinsplugins
cklosowski
on 8 Jun 2017
:+1:
pippinsplugins
on 8 Jun 2017
Themes check out, going to merge for release/2.8
cklosowski
on 26 Jun 2017
Reopening this, as it's causing some issues with customizations and support. We're going to revert this in 2.8.1, and look at getting it into a later version possibly.
cklosowski
on 28 Jul 2017
Time to get this back on the board...
cklosowski
on 22 Aug 2017
Customer asking for this to be implemented: https://secure.helpscout.net/conversation/590947577/83218?folderId=1847242
dgoldak
on 6 Jul 2018
Related issues
JJJ
路
5Comments
SDavisMedia
路
3Comments
zackkatz
路
4Comments
nabeghe
路
5Comments
mindctrl
路
4Comments
Most helpful comment
:+1: like this idea. We'll easily be able to account for our base templates and our themes, i think that's a fair set of compatibility. Themes that customize the purchase link without keeping our classes in tact might not see the change, but that should be a graceful degradation.