Easy-digital-downloads: Save used tax rate to payment meta

[flowdee]

Saving the tax rate - which was used on creating a payment - to the payment meta as well as currently the tax amount would be very helpful.

[pippinsplugins]

:+1:

[flowdee]

Do you want to give me a tip which place would be the best to save the tax rate to the payment meta? Then I'm going to take a look and create a pull request.

If you think it's a bit complicated then I'm going to wait :smile:

[pippinsplugins]

It should get stored in it's own row.

[cklosowski]

:+1: for it's own row. I'd like to get away from having nested serialized array data. This will make it much easier to isolate the data later.

[pippinsplugins]

I've gotten started on this in the issue/4105 branch but have run into a problem with reliably saving it across gateways. Since not all gateways create payments in the same way, we can't reliably set it. This may have to come after we introduce the new EDD_Gateway class.

[cklosowski]

We should be able to do this now with EDD_Payment.

[sunnyratilal]

Tracking PR opened at #5403

[sunnyratilal]

@pippinsplugins @cklosowski Ready for testing

[pippinsplugins]

@sunnyratilal This looks like it should work fine, but I'd like to keep this open in regards to changes coming with EDD_Cart and EDD_Gateway.

Ideally the tax rate doesn't depend on $_POST data inside of edd_insert_payment() since that won't be reliable in all scenarios.

[cklosowski]

Ok I've updated this to not rely on $_POST. It also adds in sending the postal code which has been requested before in #4877 to allow developers who want to do finer grain tax calculations than just country/state.

While core doesn't use it, it's a nice thing to pass along for customization.

[cklosowski]

Also added in a little bit of markup on the view order details that displays the tax rate if there is one:

[cklosowski]

@sunnyratilal @pippinsplugins ready for quick test and review of the code.

[pippinsplugins]

I don't love the rate UI.

How about adding it in parentheses after Tax, so Tax (6%):?

[spencerfinnell]

Might not even need parentheses.

[cklosowski]

It looks super odd without parenthesis...and naming it tax gives us two references to tax

[cklosowski]

So it'd be:
Tax: <input field> Tax (6%)

[spencerfinnell]

Tax: <input field> 6% looks funky?

[cklosowski]

correct.

[cklosowski]

This is the requested above...not in love with it...even less:

[cklosowski]

@spencerfinnell the reason it looks odd is because it's so disjointed from the row...seeing a random 6% hanging out after the input looks like it's disconnected from whatever is being referenced.

[cklosowski]

Here is after:

[spencerfinnell]

If the percentage is now being stored as well should that be a separate input field then? If you change the actual dollar amount but not the percentage that would be confusing.

I think either both fields need to be editable or neither.

[pippinsplugins]

I think either both fields need to be editable or neither.

I agree.

[cklosowski]

I disagree...the field will not be editable yet. It should only be allowed to be changed by the fields for address.

[cklosowski]

I'd even love to get rid of tax and total being editable since in #3802 will allow indifivul items to be updated for all of this information and we can let the EDD_Payment class handle all of the heavy lifting.

[spencerfinnell]

I agree it should be a historic recording of the original purchase and not editable.

[pippinsplugins]

:+1:

[cklosowski]

I think showing it for now is ideal and once we are comfortable with the above mentioned issue we can take View Order Details a step further and allow fully automated Tax, Total calculation for both the overall payment as well as the individual line items.

[cklosowski]

@SDavisMedia @pippinsplugins @spencerfinnell Ok, so if we settle on one...which of the following:

Camera 1: 👍

Camera 2: 🎉

[pippinsplugins]

🎉

[sunnyratilal]

Second one has my vote

[cklosowski]

🎉 It is! Thanks!

[cklosowski]

UI updated and ready for some final testing.

[pippinsplugins]

Works great. Merged and closing.