E107: sitecontactinfo and contact form have the same style ID

[Jimmi08]

$ns -> tablerender(LANCONTACT_01, $text,"contact");
$ns -> tablerender(LANCONTACT_02, $text, "contact");

could it be changed to contact-info ?
they use already different templates

$CONTACT_TEMPLATE['info']
$CONTACT_WRAPPER['form']

Thanks

[Jimmi08]

Tablerender about successful email has no id:
At least "contact" would be nice.
$ns->tablerender('', "<div class='alert alert-success'>".$message."</div>");

[Moc]

https://github.com/e107inc/e107/issues/2980

[Moc]

@fizi @Jimmi08

@CaMer0n and I were thinking to use three new ID's: contact-info, contact-form, contact-menu. This may some break existing themes but it will increase consistency and allow styling for all areas. What do you think?

[Jimmi08]

It would be great if it has some logic :
plugin and template key
yes, that suggestion is ok. And yes, it will break some themes, but it can be easily fixed. There should be a list of what to check when you update.

[fizi]

I agree with Jimmi08.

[CaMer0n]

Thank you @Jimmi08 @fizi .

Yes, I believe the correct logic for the render ID would be template name and template key.

ie.

$CONTACT_TEMPLATE['menu'] = contact-menu
$FORUM_VIEWTOPIC_TEMPLATE['replies']  = forum-viewtopic-replies

[Moc]

Updated contact.php. If you come across other inconsistencies then please list them here