E107: Forum avatar incorrect after deleting user

[Alex-e107nl]

Hi when you delete a member but this member has posted some messages in the forum this becomes a anonymous user but the avatar that is showing is from the member that is reading the forum... gives a strange effect, Moc has seen it also... Its only showing when you are logged-in.. https://e107.nl/forum/vertaling_forum/2/instellingen-scherm-probleem/

[Moc]

Confirmed.
Don't know how to best fix this to be honest.

Steps to reproduce:

• Create testuser with recognizable avatar
• Login with testuser and make post in forums
• Delete the testuser
• Go to the forum. Your own (admin) avatar shows when logged in, anonymous avatar shows when not logged in.

Reason: user_image is empty andtoAvatar() method then checks if user is logged in. If yes, it displays the avatar for this user. In fact, it should recognize that it is a deleted user and thus display the anonymous avatar.

[rica-carv]

@Moc What about something like this:
if (!isset($this->postInfo['user_image'])) {$this->postInfo['user_image']=e107::getParser()->thumbUrl(e_IMAGE."generic/blank_avatar.jpg","w=".$width."&h=".$height,true);}

I think this is better approach:
$this->postInfo['user_image']=(!isset($this->postInfo['user_image'])?"":$this->postInfo['user_image']);

before this line?

[arunshekher]

I believe no fixes has been committed for this in repository so far.

I too can confirm this issue in at-least 4 local test installations and 1 production server test installation. I tested out with a 12 year old e107 site database and static contents which was upgraded to e107 v2.1.3

Going to test out @rica-carv's solution.

[Moc]

Yes, the bug has been confirmed and is on the list to be fixed before the next release.

[CaMer0n]

Should be working now. Good to see you @arunshekher ! 👍