Dubbo: I18N effort for dubbo code base

Created on 14 Dec 2017  ·  17Comments  ·  Source: apache/dubbo

Scope

  • Translate all comments into English
  • Translate all logging message into English
  • Translate all javadoc into English
  • Remove author info
  • Change licence to apache 2.0 licence, see below:
/*
 * Licensed to the Apache Software Foundation (ASF) under one or more
 * contributor license agreements.  See the NOTICE file distributed with
 * this work for additional information regarding copyright ownership.
 * The ASF licenses this file to You under the Apache License, Version 2.0
 * (the "License"); you may not use this file except in compliance with
 * the License.  You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements.  See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License.  You may obtain a copy of the License at

     http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements.  See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License.  You may obtain a copy of the License at
#
#      http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

Assignment

| module | owner | status|
| --------------- | --------- | --------- |
| dubbo | @dubbo | done |
| dubbo-admin | @chickenlj | done |
| dubbo-cluster | @chickenlj | done |
| dubbo-common | @beiwei30 | done |
| dubbo-config | @beiwei30 | done |
| dubbo-container | @beiwei30 | done |
| dubbo-demo | @beiwei30 | done |
| dubbo-filter | @beiwei30 | done |
| dubbo-maven | @beiwei30 | done |
| dubbo-monitor | @beiwei30 | done |
| dubbo-plugin | @beiwei30 | done |
| dubbo-registry | @lovepoem | done |
| dubbo-remoting | @lovepoem | done |
| dubbo-rpc | @beiwei30 | done |
| dubbo-simple | @beiwei30 | done |
| dubbo-test | @DeadLion | done |
| hessian-lite | @aspirewit | done |

Most helpful comment

The following files still contain Chinese characters

dubbo-admin/src/main/java/com/alibaba/dubbo/governance/service/impl/ProviderServiceImpl.java
dubbo-admin/src/main/java/com/alibaba/dubbo/governance/status/MemoryStatusChecker.java
dubbo-admin/src/main/java/com/alibaba/dubbo/governance/web/common/interceptor/AuthorizationValve.java
dubbo-admin/src/main/java/com/alibaba/dubbo/governance/web/common/module/screen/Restful.java
dubbo-admin/src/main/java/com/alibaba/dubbo/governance/web/governance/module/screen/Providers.java
dubbo-admin/src/main/java/com/alibaba/dubbo/governance/web/governance/module/screen/Routes.java
dubbo-admin/src/main/java/com/alibaba/dubbo/registry/common/domain/Operation.java
dubbo-admin/src/main/java/com/alibaba/dubbo/registry/common/route/ParseUtils.java
dubbo-admin/src/main/java/com/alibaba/dubbo/registry/common/route/RouteUtils.java
dubbo-admin/src/main/java/com/alibaba/dubbo/registry/common/status/MemoryStatusChecker.java
dubbo-admin/src/test/java/com/alibaba/dubbo/registry/common/route/ParseUtilsTest.java
dubbo-admin/src/test/java/com/alibaba/dubbo/registry/common/route/RouteUtilsTest.java
dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/configurator/AbstractConfigurator.java
dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/support/FailbackClusterInvoker.java
dubbo-cluster/src/test/java/com/alibaba/dubbo/rpc/cluster/router/script/ScriptRouterTest.java
dubbo-cluster/src/test/java/com/alibaba/dubbo/rpc/cluster/support/wrapper/MockClusterInvokerTest.java
dubbo-common/src/main/java/com/alibaba/dubbo/common/beanutil/JavaBeanSerializeUtil.java
dubbo-common/src/main/java/com/alibaba/dubbo/common/status/support/MemoryStatusChecker.java
dubbo-common/src/main/java/com/alibaba/dubbo/common/threadpool/support/AbortPolicyWithReport.java
dubbo-common/src/main/java/com/alibaba/dubbo/common/URL.java
dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/extensionloader/ext1/SimpleExt.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/extensionloader/ext2/Ext2.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/io/BytesTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/json/JSONTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/serialize/dubbo/BuilderTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/serialize/serialization/AbstractSerializationTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/serialize/SerializationCompareTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/URLTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/ConfigUtilsTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/PojoUtilsTest.java
dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ReferenceConfig.java
dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/url/test/UrlTestBase.java
dubbo-plugin/dubbo-qos/src/main/java/com/alibaba/dubbo/qos/textui/TTable.java
dubbo-registry/dubbo-registry-api/src/test/java/com/alibaba/dubbo/registry/PerformanceRegistryTest.java
dubbo-registry/dubbo-registry-default/src/test/java/com/alibaba/dubbo/registry/dubbo/RegistryDirectoryTest.java
dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/Dispatcher.java
dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/Endpoint.java
dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/exchange/codec/ExchangeCodec.java
dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/exchange/support/header/HeaderExchangeClient.java
dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/AbstractClient.java
dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/AbstractPeer.java
dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/AbstractServer.java
dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/connection/ConnectionOrderedChannelHandler.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/ChanelHandlerTest.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/codec/ExchangeCodecTest.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/codec/TelnetCodecTest.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/handler/ConnectChannelHandlerTest.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/PerformanceClientCloseTest.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/PerformanceClientTest.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/PerformanceServerTest.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/transport/codec/DeprecatedExchangeCodec.java
dubbo-remoting/dubbo-remoting-grizzly/src/main/java/com/alibaba/dubbo/remoting/transport/grizzly/GrizzlyCodecAdapter.java
dubbo-remoting/dubbo-remoting-mina/src/main/java/com/alibaba/dubbo/remoting/transport/mina/MinaClient.java
dubbo-remoting/dubbo-remoting-netty/src/main/java/com/alibaba/dubbo/remoting/transport/netty/NettyClient.java
dubbo-remoting/dubbo-remoting-netty/src/test/java/com/alibaba/dubbo/remoting/transport/netty/ClientReconnectTest.java
dubbo-remoting/dubbo-remoting-netty4/src/main/java/com/alibaba/dubbo/remoting/transport/netty4/NettyClient.java
dubbo-rpc/dubbo-rpc-api/src/main/java/com/alibaba/dubbo/rpc/filter/ContextFilter.java
dubbo-rpc/dubbo-rpc-api/src/main/java/com/alibaba/dubbo/rpc/RpcContext.java
dubbo-rpc/dubbo-rpc-api/src/main/java/com/alibaba/dubbo/rpc/RpcStatus.java
dubbo-rpc/dubbo-rpc-api/src/main/java/com/alibaba/dubbo/rpc/support/ProtocolUtils.java
dubbo-rpc/dubbo-rpc-api/src/test/java/com/alibaba/dubbo/rpc/filter/AccessLogFilterTest.java
dubbo-rpc/dubbo-rpc-default/src/test/java/com/alibaba/dubbo/rpc/protocol/dubbo/ExplicitCallbackTest.java
dubbo-rpc/dubbo-rpc-injvm/src/main/java/com/alibaba/dubbo/rpc/protocol/injvm/InjvmProtocol.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/ServerExceptionTest.java
dubbo-test/dubbo-test-benchmark/src/main/java/com/alibaba/dubbo/rpc/benchmark/AbstractBenchmarkServer.java

All 17 comments

dubbo-registry module is finished in https://github.com/alibaba/dubbo/issues/1046

dubbo-remoting module is finished in https://github.com/alibaba/dubbo/issues/1055

how to join this assignment?

@DeadLion you can start from dubbo-test first

@beiwei30 ok , dubbo-test module is mine

sure, submit pull request when you finish, and we can assign you more :) @DeadLion

I also hope to join this assignment, can you assign hessian-lite to me?

sure, thanks for your kindness, hessian-lite is yours @aspirewit

The following files still contain Chinese characters

dubbo-admin/src/main/java/com/alibaba/dubbo/governance/service/impl/ProviderServiceImpl.java
dubbo-admin/src/main/java/com/alibaba/dubbo/governance/status/MemoryStatusChecker.java
dubbo-admin/src/main/java/com/alibaba/dubbo/governance/web/common/interceptor/AuthorizationValve.java
dubbo-admin/src/main/java/com/alibaba/dubbo/governance/web/common/module/screen/Restful.java
dubbo-admin/src/main/java/com/alibaba/dubbo/governance/web/governance/module/screen/Providers.java
dubbo-admin/src/main/java/com/alibaba/dubbo/governance/web/governance/module/screen/Routes.java
dubbo-admin/src/main/java/com/alibaba/dubbo/registry/common/domain/Operation.java
dubbo-admin/src/main/java/com/alibaba/dubbo/registry/common/route/ParseUtils.java
dubbo-admin/src/main/java/com/alibaba/dubbo/registry/common/route/RouteUtils.java
dubbo-admin/src/main/java/com/alibaba/dubbo/registry/common/status/MemoryStatusChecker.java
dubbo-admin/src/test/java/com/alibaba/dubbo/registry/common/route/ParseUtilsTest.java
dubbo-admin/src/test/java/com/alibaba/dubbo/registry/common/route/RouteUtilsTest.java
dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/configurator/AbstractConfigurator.java
dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/support/FailbackClusterInvoker.java
dubbo-cluster/src/test/java/com/alibaba/dubbo/rpc/cluster/router/script/ScriptRouterTest.java
dubbo-cluster/src/test/java/com/alibaba/dubbo/rpc/cluster/support/wrapper/MockClusterInvokerTest.java
dubbo-common/src/main/java/com/alibaba/dubbo/common/beanutil/JavaBeanSerializeUtil.java
dubbo-common/src/main/java/com/alibaba/dubbo/common/status/support/MemoryStatusChecker.java
dubbo-common/src/main/java/com/alibaba/dubbo/common/threadpool/support/AbortPolicyWithReport.java
dubbo-common/src/main/java/com/alibaba/dubbo/common/URL.java
dubbo-common/src/main/java/com/alibaba/dubbo/common/utils/ReflectUtils.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/extensionloader/ext1/SimpleExt.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/extensionloader/ext2/Ext2.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/io/BytesTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/json/JSONTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/serialize/dubbo/BuilderTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/serialize/serialization/AbstractSerializationTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/serialize/SerializationCompareTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/URLTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/ConfigUtilsTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/PojoUtilsTest.java
dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ReferenceConfig.java
dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/url/test/UrlTestBase.java
dubbo-plugin/dubbo-qos/src/main/java/com/alibaba/dubbo/qos/textui/TTable.java
dubbo-registry/dubbo-registry-api/src/test/java/com/alibaba/dubbo/registry/PerformanceRegistryTest.java
dubbo-registry/dubbo-registry-default/src/test/java/com/alibaba/dubbo/registry/dubbo/RegistryDirectoryTest.java
dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/Dispatcher.java
dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/Endpoint.java
dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/exchange/codec/ExchangeCodec.java
dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/exchange/support/header/HeaderExchangeClient.java
dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/AbstractClient.java
dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/AbstractPeer.java
dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/AbstractServer.java
dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/transport/dispatcher/connection/ConnectionOrderedChannelHandler.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/ChanelHandlerTest.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/codec/ExchangeCodecTest.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/codec/TelnetCodecTest.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/handler/ConnectChannelHandlerTest.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/PerformanceClientCloseTest.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/PerformanceClientTest.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/PerformanceServerTest.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/transport/codec/DeprecatedExchangeCodec.java
dubbo-remoting/dubbo-remoting-grizzly/src/main/java/com/alibaba/dubbo/remoting/transport/grizzly/GrizzlyCodecAdapter.java
dubbo-remoting/dubbo-remoting-mina/src/main/java/com/alibaba/dubbo/remoting/transport/mina/MinaClient.java
dubbo-remoting/dubbo-remoting-netty/src/main/java/com/alibaba/dubbo/remoting/transport/netty/NettyClient.java
dubbo-remoting/dubbo-remoting-netty/src/test/java/com/alibaba/dubbo/remoting/transport/netty/ClientReconnectTest.java
dubbo-remoting/dubbo-remoting-netty4/src/main/java/com/alibaba/dubbo/remoting/transport/netty4/NettyClient.java
dubbo-rpc/dubbo-rpc-api/src/main/java/com/alibaba/dubbo/rpc/filter/ContextFilter.java
dubbo-rpc/dubbo-rpc-api/src/main/java/com/alibaba/dubbo/rpc/RpcContext.java
dubbo-rpc/dubbo-rpc-api/src/main/java/com/alibaba/dubbo/rpc/RpcStatus.java
dubbo-rpc/dubbo-rpc-api/src/main/java/com/alibaba/dubbo/rpc/support/ProtocolUtils.java
dubbo-rpc/dubbo-rpc-api/src/test/java/com/alibaba/dubbo/rpc/filter/AccessLogFilterTest.java
dubbo-rpc/dubbo-rpc-default/src/test/java/com/alibaba/dubbo/rpc/protocol/dubbo/ExplicitCallbackTest.java
dubbo-rpc/dubbo-rpc-injvm/src/main/java/com/alibaba/dubbo/rpc/protocol/injvm/InjvmProtocol.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/ServerExceptionTest.java
dubbo-test/dubbo-test-benchmark/src/main/java/com/alibaba/dubbo/rpc/benchmark/AbstractBenchmarkServer.java

@aspirewit I'm fixing these from bottom up. Anyone else want to help can start top down to avoid repetition.

NOTE: I will add a PR for this, #1126

The following files have not been added the Apache 2.0 license

dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/merger/SetMerger.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/$__ClassNameTestDubboStub.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/ClassNameTestDubbo.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/ClassNameTestThrift.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/gen/dubbo/$__DemoStub.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/gen/dubbo/Demo.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/gen/thrift/Demo.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/AbstractTest.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/DemoImpl.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/DubboDemoImpl.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/examples/DubboDemoConsumer.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/examples/DubboDemoProvider.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/FramedTransportFactory.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/MockedChannel.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/ServerExceptionTest.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/ServiceMethodNotFoundTest.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/ThriftCodecTest.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/ThriftDemoImpl.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/ThriftProtocolTest.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/ThriftUtilsTest.java

The following files still contain the author information

dubbo-admin/src/main/java/com/alibaba/dubbo/registry/common/util/Entities.java
dubbo-admin/src/main/java/com/alibaba/dubbo/registry/common/util/IntHashMap.java
dubbo-admin/src/main/java/com/alibaba/dubbo/registry/common/util/StringEscapeUtils.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/model/person/PersonInfo.java
dubbo-rpc/dubbo-rpc-injvm/src/test/java/com/alibaba/dubbo/rpc/protocol/injvm/ProtocolTest.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/AbstractTest.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/DemoImpl.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/DubboDemoImpl.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/examples/DubboDemoConsumer.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/examples/DubboDemoProvider.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/FramedTransportFactory.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/MockedChannel.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/ServerExceptionTest.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/ServiceMethodNotFoundTest.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/ThriftCodecTest.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/ThriftDemoImpl.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/ThriftProtocolTest.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/ThriftUtilsTest.java
dubbo-test/dubbo-test-examples/src/test/java/com/alibaba/dubbo/examples/validation/ValidationTest.java

I used the following ruby script to check the contents of the files

require 'pathname'

DUBBO_ROOT_PATH = '/Users/richard/Repositories/dubbo/'
DUBBO_ROOT_PATH_NAME = Pathname.new(DUBBO_ROOT_PATH)
source_files = Dir[File.join(DUBBO_ROOT_PATH, '**/*.java')]

def check_file_content(files)
  files.each do |file_name|
    content = File.read(file_name)
    puts Pathname.new(file_name).relative_path_from(DUBBO_ROOT_PATH_NAME) if yield(content)
  end
end

check_file_content(source_files) { |content| content !~ /Scott Ferguson/ && content !~ %r(http://www.apache.org/licenses/LICENSE-2.0) } # check the license
check_file_content(source_files) { |content| content =~ /@author(?! Scott Ferguson)|Created by/ } # check the author information
check_file_content(source_files) { |content| content =~ /\p{Han}/ } # check Chinese characters

thanks, will follow up. I will take care dubbo-common first

@aspirewit @beiwei30
All problems @aspirewit put forward have done, please review.
I'm sorry i didn't notice your PR, so i fixed it myself. Thank you very much for your effort.

@chickenlj Nice, but still some files are not completely processed.

The following files still contain Chinese characters, it may also be some Chinese test data, please double check.

dubbo-admin/src/main/java/com/alibaba/dubbo/governance/web/governance/module/screen/Routes.java
dubbo-admin/src/main/java/com/alibaba/dubbo/registry/common/route/RouteUtils.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/io/BytesTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/json/JSONTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/serialize/dubbo/BuilderTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/serialize/serialization/AbstractSerializationTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/serialize/SerializationCompareTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/PojoUtilsTest.java
dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/url/test/UrlTestBase.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/codec/ExchangeCodecTest.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/codec/TelnetCodecTest.java
dubbo-remoting/dubbo-remoting-grizzly/src/main/java/com/alibaba/dubbo/remoting/transport/grizzly/GrizzlyCodecAdapter.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/protocol/thrift/ServerExceptionTest.java

The following files have not been added the new license

dubbo-common/src/main/java/com/alibaba/dubbo/common/extension/ExtensionLoader.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/StringUtilsTest.java
dubbo-registry/dubbo-registry-redis/src/main/java/com/alibaba/dubbo/registry/redis/RedisRegistry.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/PerformanceClientTest.java
dubbo-remoting/dubbo-remoting-grizzly/src/main/java/com/alibaba/dubbo/remoting/transport/grizzly/GrizzlyClient.java
dubbo-remoting/dubbo-remoting-netty/src/main/java/com/alibaba/dubbo/remoting/transport/netty/NettyCodecAdapter.java
dubbo-rpc/dubbo-rpc-api/src/main/java/com/alibaba/dubbo/rpc/filter/tps/DefaultTPSLimiter.java
dubbo-rpc/dubbo-rpc-api/src/main/java/com/alibaba/dubbo/rpc/filter/tps/StatItem.java
dubbo-rpc/dubbo-rpc-api/src/main/java/com/alibaba/dubbo/rpc/filter/tps/TPSLimiter.java
dubbo-test/dubbo-test-examples/src/test/java/com/alibaba/dubbo/examples/validation/ValidationTest.java

Some files do have Chinese Characters for testing, i have fixed the rest. 7322f3ead103c4acbe2123404add364745a0a054

I don't have a ruby environment, so i haven't run your script. It's a good practice checking with a script.

I run the ruby script @aspirewit provided,the result is :

check the license

dubbo-rpc/dubbo-rpc-thrift/src/test/java/ClassNameTestDubbo.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/ClassNameTestThrift.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/gen/thrift/Demo.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/gen/dubbo/$__DemoStub.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/com/alibaba/dubbo/rpc/gen/dubbo/Demo.java
dubbo-rpc/dubbo-rpc-thrift/src/test/java/$__ClassNameTestDubboStub.java

check the author information

None

check Chinese characters

dubbo-common/src/test/java/com/alibaba/dubbo/common/io/BytesTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/serialize/serialization/AbstractSerializationTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/serialize/dubbo/BuilderTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/serialize/SerializationCompareTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/PojoUtilsTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/json/JSONTest.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/codec/TelnetCodecTest.java
dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/url/test/UrlTestBase.java

Files without license is automatically generated and do not need to be process.

Updated ruby script

require 'pathname'

DUBBO_ROOT_PATH = '/Users/richard/Repositories/dubbo/'
DUBBO_ROOT_PATH_NAME = Pathname.new(DUBBO_ROOT_PATH)
source_files = Dir[File.join(DUBBO_ROOT_PATH, '**/*.java')]

without_hessian_lite_source_files = source_files.reject { |file_name| file_name =~ /hessian-lite/ }
def check_file_content(files)
  files.each do |file_name|
    content = File.read(file_name)
    puts Pathname.new(file_name).relative_path_from(DUBBO_ROOT_PATH_NAME) if yield(content)
  end
end

check_file_content(without_hessian_lite_source_files) { |content| content !~ /Autogenerated by/ && !content.include?('Licensed to the Apache Software Foundation (ASF) under one or more') }
check_file_content(without_hessian_lite_source_files) { |content| content =~ /@author|Created by/ }
check_file_content(source_files) { |content| content =~ /\p{Han}/ }

The result

check the license

None

check the author information

None

check Chinese characters (@chickenlj has checked it, there should be no need to process it)

dubbo-common/src/test/java/com/alibaba/dubbo/common/io/BytesTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/json/JSONTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/serialize/dubbo/BuilderTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/serialize/serialization/AbstractSerializationTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/serialize/SerializationCompareTest.java
dubbo-common/src/test/java/com/alibaba/dubbo/common/utils/PojoUtilsTest.java
dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/url/test/UrlTestBase.java
dubbo-remoting/dubbo-remoting-api/src/test/java/com/alibaba/dubbo/remoting/codec/TelnetCodecTest.java
Was this page helpful?
0 / 5 - 0 ratings