Dpl: Heroku build results is now 410 gone

[simmerz]

dpl doesn't return a exit code any more because the build result on heroku's platform API no longer exists: https://devcenter.heroku.com/articles/platform-api-reference#build-result

https://devcenter.heroku.com/articles/api-compatibility-policy#deprecation explains their deprecation policy.

This means it hangs in CI/CD environments

[cotsog]

@simmerz this should be fixed by https://github.com/travis-ci/dpl/pull/917.

Do you think you could help us validate the fix by running a build with the following in your .travis.yml file?

deploy:
  provider: heroku
  edge: true
  ⋮

Thanks in advance!

[simmerz]

I added #919 at about the same time. Seems we were all thinking the same thing. Want me to add the above to my PR anyway @cotsog ?

[cotsog]

@simmerz Indeed! Such serendipity! :)

We already got some confirmations in https://github.com/travis-ci/dpl/pull/917 so I think we are good.

I'm synchronizing things with our Engineering Team to get a new release of dpl out tomorrow.

Thanks again for your help and patience!

[escottalexander]

I believe I am having the same problem. Here is my build log: https://gist.github.com/escottalexander/ee1809e4710cfcaa32bd305a2784f8c4
In a nutshell, Travis hangs on "Heroku build still pending" when in fact, Heroku app is live. I will test your instruction, to verify it is fixed.

[escottalexander]

This worked for me,

deploy:
  provider: heroku
  edge: true

[cotsog]

New dpl version with this fix has now been released.

Please let us know if you are still having issues.

Thanks again everyone!

[cklanac]

@cotsog I just want to confirm... the edge: true entry was only to resolve the issue while dpl was being updated. Now that you have released a new version of dpl, the edge key is no longer needed.

[cotsog]

@cklanac I confirm that the edge: key is no longer needed (i.e. since the new version of dpl has been deployed).

[acanimal]

Works fine from gitlab-ci too ! Congrats 🎩

[gopeter]

Hi @acanimal,

which version do you use? We're running self-hosted GitLab (11.6.0) and different GitLab runners (11.7.0) (Docker ones on DigitalOcean and SSH ones on own machines), but we're just getting ...

heroku build still pending
heroku build still pending
heroku build still pending
heroku build still pending
heroku build still pending
heroku build still pending
heroku build still pending
heroku build still pending

dpl gem version is the right one:

$ gem install dpl
Successfully installed dpl-1.10.7
Parsing documentation for dpl-1.10.7
Done installing documentation for dpl after 0 seconds
1 gem installed

Any ideas? :-)

[gopeter]

Update to Ruby 2.6.1 (from 2.3.1) did the trick 👍