Dpl: Filter out bad characters for elastic beanstalk description

Created on 15 Jun 2016  路  8Comments  路  Source: travis-ci/dpl

Ran into this strange issue where our travis builds were failing with the following message:

/home/travis/.rvm/gems/ruby-1.9.3-p551/gems/aws-sdk-v1-1.66.0/lib/aws/core/client.rb:375:in `return_or_raise': Invalid unicode xml character in CreateApplicationVersionMessage.Description at index 74 (AWS::ElasticBeanstalk::Errors::InvalidParameterValue)
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/aws-sdk-v1-1.66.0/lib/aws/core/client.rb:476:in `client_request'
    from (eval):3:in `create_application_version'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/dpl-1.8.16/lib/dpl/provider/elastic_beanstalk.rb:138:in `create_app_version'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/dpl-1.8.16/lib/dpl/provider/elastic_beanstalk.rb:45:in `push_app'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/dpl-1.8.16/lib/dpl/provider.rb:143:in `block in deploy'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/dpl-1.8.16/lib/dpl/cli.rb:41:in `fold'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/dpl-1.8.16/lib/dpl/provider.rb:143:in `deploy'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/dpl-1.8.16/lib/dpl/cli.rb:32:in `run'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/dpl-1.8.16/lib/dpl/cli.rb:7:in `run'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/dpl-1.8.16/bin/dpl:5:in `<top (required)>'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/bin/dpl:23:in `load'
    from /home/travis/.rvm/gems/ruby-1.9.3-p551/bin/dpl:23:in `<main>'

Turns out the last merge commit had a message with the following character: 馃憤
Dpl was attempting to append this commit message to the version description of the elastic beanstalk application, and failing every time. It would be nice if there was some filtering of characters in the application version description to line up with the requirements of elastic beanstalk application version descriptions. Or at least a slightly more clear error message.

stale
Source
picture dloiko

Most helpful comment

Having this problem now D:

picture jjwatson on 4 Apr 2019
👍8

All 8 comments

Same issue here with 馃帀. Would be great to get it resolved and allow our developers to properly emote their commits. 馃弽 without crashing the beanstalk upload.

``Deploying application /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/aws-sdk-v1-1.66.0/lib/aws/core/client.rb:375:inreturn_or_raise': Invalid unicode xml character in CreateApplicationVersionMessage.Description at index 0 (AWS::ElasticBeanstalk::Errors::InvalidParameterValue)
from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/aws-sdk-v1-1.66.0/lib/aws/core/client.rb:476:in client_request' from (eval):3:increate_application_version'
from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/dpl-1.8.32.travis.1901.6/lib/dpl/provider/elastic_beanstalk.rb:143:in create_app_version' from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/dpl-1.8.32.travis.1901.6/lib/dpl/provider/elastic_beanstalk.rb:49:inpush_app'
from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/dpl-1.8.32.travis.1901.6/lib/dpl/provider.rb:146:in block in deploy' from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/dpl-1.8.32.travis.1901.6/lib/dpl/cli.rb:41:infold'
from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/dpl-1.8.32.travis.1901.6/lib/dpl/provider.rb:146:in deploy' from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/dpl-1.8.32.travis.1901.6/lib/dpl/cli.rb:32:inrun'
from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/dpl-1.8.32.travis.1901.6/lib/dpl/cli.rb:7:in run' from /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/dpl-1.8.32.travis.1901.6/bin/dpl:5:in from /home/travis/.rvm/gems/ruby-1.9.3-p551/bin/dpl:23:in load' from /home/travis/.rvm/gems/ruby-1.9.3-p551/bin/dpl:23:in

'
failed to deploy

tzaitsev picture tzaitsev on 14 Mar 2017

I believe https://github.com/travis-ci/dpl/pull/600 will resolve this issue.

thisandagain picture thisandagain on 20 Mar 2017

Did some research, found that the #600 is not quite there yet. https://github.com/aws/aws-sdk-ruby/issues/1502 will hopefully clarify which characters should be rejected.

Thank you for your patience.

BanzaiMan picture BanzaiMan on 28 Apr 2017

Same problem. No solution yet?

Jolg42 picture Jolg42 on 3 Oct 2017

I've commented on https://github.com/aws/aws-sdk-ruby/issues/1502 again.

BanzaiMan picture BanzaiMan on 3 Oct 2017
👍1

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues

stale[bot] picture stale[bot] on 12 Apr 2018

I think the issue is still not resolved...!

Jolg42 picture Jolg42 on 13 Apr 2018
👍5

Having this problem now D:

jjwatson picture jjwatson on 4 Apr 2019
👍8
Was this page helpful?
0 / 5 - 0 ratings

Related issues

amblock picture amblock  路  5Comments
rodmoreno picture rodmoreno  路  3Comments
ruzicka picture ruzicka  路  4Comments
Sytten picture Sytten  路  4Comments
gbleu picture gbleu  路  7Comments