It is not clear what is the lister used in some code snippets that and where it is declared.
⚠Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
Thanks for pointing this out @bempelise
I've added it to our backlog, and added the up-for-grabs label to this issue.
@BillWagner / @Thraka I think instead of the FilesList example you'd be better served, given the past tense/present tense "typical" language, using something like FileSaveArgs so we'd have FileSaving and FileSaved instead of Progress to work with. Then we could could give examples of both a cancellable event in Saving and a notification event in Saved.
or if you want to follow on the examples later we could use Searched and Searching. The names are basically meaningless but they help to solidify the concept if we don't jump all over the place.
I know it was easier for me learning a concept when the examples fully followed on the text in some consistent concrete, practical example. The directory example is great but I can't think of a practical example of a reason for cancelling the file listing?
Love to help out if this isn't assigned already
@jwwicks Thank you for volunteering :) I'll move this issue to In Progress.
Regarding your suggestions. I believe this article was trying to use the file analogy to make more sense with the next article. But this article is the introduction and doesn't define what these events mean, so there is no context. We have more free reign here since the next article really introduces that file args/event concept.
With that said, I think we should keep this simple. Maybe we should just change it to something generic like Alert or Completed.
Personally, I don't like the section Language Support for Events. I think this should briefly discuss the event pattern and demonstrate it. A bit more clearer than it does now. This gives us a good introduction to the next section, the event pattern.
@BillWagner thoughts?
Related to #9288
assigned to @BillWagner as we wait for his thoughts on my suggestion of redoing that section.
@Thraka
I like your suggestions. I'm removing the "waiting on feedback" label.
@jwwicks are you still interested in doing this work?
Yep, are we ok moving forward? Just catching up I think I missed a
notification.
Jw
On Thu, Nov 7, 2019 at 12:28 PM Andy De George notifications@github.com
wrote:
@jwwicks https://github.com/jwwicks are you still interested in doing
this work?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dotnet/docs/issues/5926?email_source=notifications&email_token=AAFLRBHBVJW5YM62AEQ2I7TQSR26VA5CNFSM4FEVBBX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDNWOYI#issuecomment-551249761,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFLRBBCPO24LKXRQPY4Y4TQSR26VANCNFSM4FEVBBXQ
.
--
John Wicks
Web Application Developer
(916) 538-1857
Without the wind, the grass does not move. Without software, hardware is
useless.
@Thraka I'll get started on it using the Alert suggestion and make it more generic. I'll keep you updated.
@Thraka FYI I'm in the process of moving into a new home so might be a little slow in getting this done.
@jwwicks We can continue to wait. This isn't a high priority fix for us so you helping out (when you can) is wonderful. I'm just keeping it moving by pinging you. 😄