Dockstore: Tool with only Descriptor and no Dockerfile leads to UI issue

Created on 1 Aug 2018  路  5Comments  路  Source: dockstore/dockstore

Bug Report

Expected behaviour

Add a Dockstore.cwl to a repo, no Dockerfile.
Add as a Docker Hub tool with an arbitrary path on Docker hub leading to your legit repo.
Refresh, should be able to see Dockstore.cwl, a warning due to no Dockerfile

Actual behaviour

The Files tab displays no content at all.

bug gui

All 5 comments

This occurs because the version is not valid (no Dockerfile). We can either display a message saying the version is not valid or we can just display the file anyways. Thoughts?

I think it makes sense to display a warning if you try to view the Dockerfile when there isn't.
I don't think it makes sense to hide the Dockstore.cwl when the Dockerfile is absent.
I could be convinced that a warning for both could be displayed saying that the version is invalid, but the existing file should be displayed regardless

FYI, double check

Looks like this nowadays:

image

File is displayed even though version is invalid. Warning about invalid version is displayed too.

Looks good on

DockstoreAPI - 1.5.0-beta.2
DockstoreUI - 2.2.0-beta.0
Was this page helpful?
0 / 5 - 0 ratings