Docker-stacks: tini license is not available from within the Docker image

[tylere]

The tini library has an MIT license, which includes the requirement:

The above copyright notice and this permission notice shall be included in
all copies or substantial portions of the Software.

However, the base_notebook container image only copies the tini binary file (via wget), and does not include a copy of license in the container image.

[parente]

Good catch. Do you know if the many official docker images that include tini pull the license text in or take some alternative route? I'd like to mimic whatever the official images do here.

[parente]

Or https://github.com/krallin/tini/issues/46 ...

[tylere]

I don't know of any docker images that use tini and pull the license text. Jenkins appears to do something similar to docker-stacks.

[parente]

We're all copy/pasta-ing the recipe from the tini readme (unfortunately).

I think @jakirkham has the right idea in krallin/tini#46, or at least we'll settle on a best practice for including it that everyone can adopt.

[jakirkham]

Sorry, meant to xref that back here. Including the license in the binary seems like the simple way to ensure everyone is compliant. Though if we want to put it in somewhere like /usr/share/tini that could work. For some other projects I have used the rpm, which doesn't appear to include the license either.

[tylere]

Here are a few options the could be used to include it, without modifying the binary file.

1. Along the lines of the Using tini section of the tini docs, you could append an additional ADD command to the Dockerfile that copies the license file. The license file URL would need to be updated every time there is a new release. I.e.
   ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini
   ADD https://github.com/krallin/tini/blob/2c2bb517b0a5e283ea6dd3e561f00ae006780949/LICENSE /usr/share/tini/LICENSE
2. Following the example shown in tini-images container images, you could use git clone to pull the source code.

[jakirkham]

Just for creative flair, we could create a conda package for tini and conda has a standard way of including licenses. Honestly, it might be fun to create tini package for conda just to see that it can be done.

[parente]

All of these sound reasonable. Let's give the author a bit of time to chime in with his preferred approach. Then we can submit a PR to update the Docker recipe upstream in the tini README and all roll with the same solution.

[krallin]

Hey folks; thanks a lot for opening an issue in Tini for this! As commented in https://github.com/krallin/tini/issues/46, I've prepared a commit to let Tini output its own license via the -l flag.

Will that work for everyone involved here?

Thanks!

[tylere]

That works for me. Thank you for preparing the commit.

On Wed, Aug 10, 2016 at 12:02 AM Thomas Orozco [email protected]
wrote:

Hey folks; thanks a lot for opening an issue in Tini for this! As
commented in krallin/tini#46 https://github.com/krallin/tini/issues/46,
I've prepared a commit to let Tini output its own license via the -l
flag.

Will that work for everyone involved here?

Thanks!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jupyter/docker-stacks/issues/256#issuecomment-238782717,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFqvoC_hIz9kAUIFL17Thv3taWo0Rtaks5qeXeQgaJpZM4JgSam
.

[jakirkham]

👍 Thanks @krallin. Does this seem reasonable to you, @parente?

[parente]

Perfectly fine by me. Thanks @krallin.

Once there's a tini binary release with the license flag, we'll include it here in stacks. I'll leave this issue open as a reminder.

[krallin]

Hi there,

I just released Tini 0.10.0, which embeds the license in the binary and lets the user print it out via tini -l!

Cheers,

[jakirkham]

Thanks so much @krallin. 😄

[jakirkham]

Updating tini in PR ( https://github.com/jupyter/docker-stacks/pull/260 ).