Dim: The total stat field in the item popup doesn't indicate if mods are included.
In the following panel the total is inclusive of a stat increasing mod.
I was thinking it would be clearer to display the base stat value with a +10 (or whatever the mod total is) next to it in the same blue as the stat bars have.
Thoughts?
ryan-rushton
All 8 comments
delphiactual
on 19 Oct 2019
@delphiactual, there wasn't an issue for that PR so I figured I would make one. Although, it would make sense to do them at the same time.
ryan-rushton
on 19 Oct 2019
I think what @ryan-rushton is asking is slightly different, but it makes sense. One confusion is that I believe in-game the total will include mods. So we'd just need to be consistent about how we displayed them to make sure we're always showing the base, mod value, and true total.
bhollis
on 19 Oct 2019
Since I did some stuff in the area, I will do a mock up for this post up some shots to get opinions.
ryan-rushton
on 20 Oct 2019
What are the thoughts on this?
I have partly done the masterwork side of things, basically it would display a plus with an orange number after the mod value if it is non zero. I am just not sure how the new values are calculated and I haven't masterworked a piece of armour yet to figure this out.
ryan-rushton
on 20 Oct 2019
That looks good! I think @sundevour was telling me a masterwork gets +2 in all stats.
bhollis
on 20 Oct 2019
i like this a lot!
masterworks right now are a fixed +2 bonus, in all 6 stats.
archived-2f4dd0
on 20 Oct 2019
Cool, I will raise a PR for this today some time.
ryan-rushton
on 20 Oct 2019
Related issues
dhazelett
路
5Comments
cbcrouse
路
4Comments
AdamAlgaert
路
5Comments
SunburnedGoose
路
4Comments
KyoukanGG
路
3Comments
Most helpful comment
I think what @ryan-rushton is asking is slightly different, but it makes sense. One confusion is that I believe in-game the total will include mods. So we'd just need to be consistent about how we displayed them to make sure we're always showing the base, mod value, and true total.