Dex: incorrect response for github connector is user not in required org

[jtnord]

if the user is not in the required github or then dex returns 500 along with "Failed to authenticate: github: user "wibble" is not in required orgs or teams".

However - this should not be a 500 error code but a 403 - the user is authenticated - they just have no authorisation to proceed.

or to put it another way the Internal server error makes it look to the user as though this is something that can be fixed by retrying.

[jtnord]

see https://github.com/dexidp/dex/blob/c113df2730052e20881dd68561289f8ae121300b/connector/github/github.go#L389

[srenatus]

Yeah, it would be good to be able to differentiate these! 😃

[imrenagi]

can i take this one?