Dex: background health check

Created on 6 Feb 2019  路  3Comments  路  Source: dexidp/dex

As noted here https://github.com/dexidp/dex/pull/1397#issuecomment-460852910, there's more clever approaches we could do. Right now, it'll run the health check every 15 seconds.

I suppose something like an exponential back-off (capped at some max duration) could make sense?

if the first check doesn't succeed, try again in 5s; if it does succeed, try again in 25s; etc

鈽濓笍 just a guess, all suggestions are welcome 馃槂

areusability help wanted kinenhancement

All 3 comments

I wouldn't mind taking this on, extending health check retries on subsequent successful attempt makes sense. That being said I propose capping the time limit to a value that makes sense (5 minutes is my initial thought).

@soggiest great, thank you 馃槂 A five minutes cap seems reasonable, too. (馃挱 I guess it could be made configurable; but that doesn't have to go into the first iteration.)

/assign @soggiest
Edit: Wow, I'm so used to Prow commands from the kubernetes/kubernetes repo that I assume they're everywhere. I'm leaving this in as a marker of my shame

Was this page helpful?
0 / 5 - 0 ratings