Devilutionx: Cant resize window after toggeling full screen

Created on 24 Mar 2020  路  6Comments  路  Source: diasurgical/devilutionX

When switching from full screen to window mod with alt+enter it's not possible to resize the window even when upscaling is enabled.

bug good first issue

All 6 comments

is that because the resolution of the window is 640x480
is it a SDL issue?

No, it is simply because we do not set the SDL_WINDOW_RESIZABLE when starting the game in fullscreen mode:
https://github.com/diasurgical/devilutionX/blob/master/SourceX/display.cpp#L83

Should be simple to fix.

@AJenbo in this case, it would solve it?

    if (fullscreen) {
        flag |= SDL_WINDOW_FULLSCREEN_DESKTOP;
    }
    flags |= SDL_WINDOW_RESIZABLE;

Feel free to send a PR

tested this fix with my latest build
working great

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ctrl-meta-f picture ctrl-meta-f  路  30Comments

spitfire picture spitfire  路  22Comments

rsn8887 picture rsn8887  路  14Comments

baszczewski picture baszczewski  路  15Comments

Chance4us picture Chance4us  路  27Comments