Devilutionx: Mouse doesn't register events on left most and top most pixel

[Chance4us]

As of 1d500497da6d176a61896168616ca7c34d29ecfa the game doesn't react when clicking at first top or left side pixel of the screen. This both seen when walking or putting on a helmet.

This can also leave the game thinking that the mouse is continually pressed if the mouse up event happens in this part of the screen.

For testing you can use the attached save game.

single_0.sv.zip

[AJenbo]

Is this with standard settings or only upscaling 0?

PS please just post the commit hash, we can see all we need from it, no need for people's full name an private email

[AJenbo]

Cannot replicate this issue, I can apply the helmet with all combination of fullscree, grab input and upscale both with your save game and others.

[Chance4us]

"PS please just post the commit hash" -> understood.
I would ask you not to close until we have discussed everything.
The issue happens with "upscaling 0" and "upscaling 1" and "fullscreen 1".
To reproduce it is very important, that you hold the mouse cursor position on top, as high as possible. It is very important that the cursor is at the top, then the helmet does not lock into the slot.
If you try the version before the mentioned commit, the helmet locks in immediately. If you have some more questions I would be happy to contact you again.

[AJenbo]

I would ask you not to close until we have discussed everything.

We will reopen it if it can be confirmed.

[Chance4us]

Thanks a lot, nice friend. I would welcome it.

[AJenbo]

Your right that it's no longer possible to apply it at the top pixel of the screen, but I can't replicate the need to double click at all.

[Chance4us]

Greetings good master. I'm sorry, I described little bit not exactly.
A double click is not needed. But it's needed to click twice to apply the helmet.

[AJenbo]

A double click is not needed. But it's needed to click twice to apply the helmet.

I really can't replicate that part, or are you just saying that you have to click again at a lower position for it to work?

What i'm seeing:

• Infinit clicks at the top of the screen never applies the helmet
• 1 click just below always applies the helmet.

[Chance4us]

With the latest commit I can no longer replicate clicking twice as well. Only the top pixel is currently affected. Thank you for your efforts.

[AJenbo]

Fix in 7273e6a, and this should also provide a nicer solution for #91

[Chance4us]

Great commit. Now it works really fantastic.