Devilutionx: Items changing on pickup in multiplayer

[kenvieira]

I have seen a couple of issues where multiplayer games are not fully sync'd.

In one situation I purchased a magical cap for a player and dropped it for them to pick it up, when they picked it up it changed to a non-magical item. They then dropped it and I picked it up and it was now stuck as non-magical.

Another situation on my game there was one type of shrine seen, but the other play had a different shrine on screen.

Yet another instance I found a book of town portal but the game would not let me pick it up, so another player grabbed it and moved it to another location and then dropped it, but now the book was a book of inferno.

Now these issues were seen in a 3 person TCP game, My character and the other I mentioned above were clients to the master character. So seemed to be some issue with sync'ing between 2 client characters.

[AJenbo]

That's for the bug report. Some extra info that would help us try to replicate this:

Where all players using the same release? Where any of them self compiled?
If so where all or some of them 64bit builds?
What OSs where used?

[kenvieira]

Sure.. sorry for got to give those details.

All Diablo MPQ files are based on current GOG diablo image.. 1.09

All devilutionX files were binary downloads from github so not compiled.

My computer is running MacOS, the 2nd computer used was Windows based.
(interesting I didn't think to make that connection)

The server system was MacOS based. Both MacOS are using same pre-compiled
devilutionX image.

On Thu, Jul 11, 2019 at 10:38 AM Anders Jenbo [e-mail]
wrote:

That's for the bug report. Some extra info that would help us try to
replicate this:

Where all players using the same release? Where any of them self compiled?
If so where all or some of them 64bit builds?
What OSs where used?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/diasurgical/devilutionX/issues/171?email_source=notifications&email_token=ALEYXMZVKBCAE7ZLMBSLEGLP65V2HA5CNFSM4IBMN222YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXN7TI#issuecomment-510582733,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALEYXM3S3OCMRKIFQFXWVQTP65V2HANCNFSM4IBMN22Q
.

[kenvieira]

Forgot to mention one more thing.. all DevilutionX files were downloaded
within last week.. so most current version to this date..

On Thu, Jul 11, 2019 at 11:05 AM Ken Vieira [e-mail] wrote:

Sure.. sorry for got to give those details.

All Diablo MPQ files are based on current GOG diablo image.. 1.09

All devilutionX files were binary downloads from github so not compiled.

My computer is running MacOS, the 2nd computer used was Windows based.
(interesting I didn't think to make that connection)

The server system was MacOS based. Both MacOS are using same pre-compiled
devilutionX image.

On Thu, Jul 11, 2019 at 10:38 AM Anders Jenbo [e-mail]
wrote:

That's for the bug report. Some extra info that would help us try to
replicate this:

Where all players using the same release? Where any of them self compiled?
If so where all or some of them 64bit builds?
What OSs where used?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/diasurgical/devilutionX/issues/171?email_source=notifications&email_token=ALEYXMZVKBCAE7ZLMBSLEGLP65V2HA5CNFSM4IBMN222YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZXN7TI#issuecomment-510582733,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALEYXM3S3OCMRKIFQFXWVQTP65V2HANCNFSM4IBMN22Q
.

[ThomasChr]

I think I remember those bugs from the original diablo. So I‘m not sure if they are "new"...

[kenvieira]

Update.. so with more play time over the past weekend the issue was seen
again. It does seem to be tied to windows vs Mac client. What I saw was
that the Mac client (host) might see a book drop showing charge bolt, but
the windows client will show Telekinesis.. But then they can't pick it
up.. Then the mac client picks it up and drops it and the windows client
can now get it and it is set back to charge bolt.

We also saw a room with enemies are cleared out on the Mac clients, but
windows still shows active enemies but can't shoot or hit them. Those are
some of the sync issues I've seen and it generally falls between mac and
windows clients.

Since the original game did not have a Mac client this might be some new
issue seen due to the OS differences. Perhaps this might be seen between
Linux and other OS's as well.

On Tue, Jul 16, 2019 at 11:05 AM Thomas Christlieb [e-mail]
wrote:

I think I remember those bugs from the original diablo. So I‘m not sure if
they are "new"...

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/diasurgical/devilutionX/issues/171?email_source=notifications&email_token=ALEYXM2N55EC7NFRQX3PHGLP7YEWBA5CNFSM4IBMN222YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2BVRLQ#issuecomment-511924398,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALEYXM2LYXHIDEV5MP7RN63P7YEWBANCNFSM4IBMN22Q
.

[AJenbo]

Actually, the original game did have a Mac client :)

I expect that it won't be too long before we have a new release, a lot has been fixed between 0.4.0 and now, so I'm hoping this will solve the issues you are seeing, but multiplayer is one of the main things that need testing before we are ready to release 0.5.0.

[kenvieira]

well keep me in mind if you would like some testing done.. I am a test
engineer in profession (network equipment testing but mindset is still
same) and do had 2 different client hardwares we play on to give interop
coverage. At time I even can have a max 4 user game going so stress and
playability under different conditions is also possible.

On Tue, Jul 16, 2019 at 12:12 PM Anders Jenbo [e-mail]
wrote:

Actually, the original game did have a Mac client :)

I expect that it won't be too long before we have a new release, a lot has
been fixed between 0.4.0 and now, so I'm hoping this will solve the issues
you are seeing, but multiplayer is one of the main things that need testing
before we are ready to release 0.5.0.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/diasurgical/devilutionX/issues/171?email_source=notifications&email_token=ALEYXM3FOYUKSB5W6HAY3PDP7YMRHA5CNFSM4IBMN222YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2B3HDQ#issuecomment-511947662,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALEYXM3DBINZJIH2ZAAP4GDP7YMRHANCNFSM4IBMN22Q
.

[AJenbo]

@kenvieira would you be able to test the latest code to see if this is solved before we do a 0.5.0 release. Also feel free to test on native 64bit.

[kenvieira]

Hi Anders,

Sure I can give the new code a few test runs. Is there a place I can
download the windows and Mac compiled versions of this code?

Ken

On Sun, Sep 15, 2019 at 7:21 AM Anders Jenbo [e-mail]
wrote:

@kenvieira https://github.com/kenvieira would you be able to test the
latest code to see if this is solved before we do a 0.5.0 release. Also
feel free to test on native 64bit.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/diasurgical/devilutionX/issues/171?email_source=notifications&email_token=ALEYXMZZHUNEAF5AK3THTK3QJZAHNA5CNFSM4IBMN222YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6XRVEA#issuecomment-531569296,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALEYXMYJUX7RROG2C5Q4J43QJZAHNANCNFSM4IBMN22Q
.

[AJenbo]

You can always download the latest windows, Linux and Nintendo switch builds from CircleCi builds (you need to be logged in via Github) via the artifacts tab. Here is the latest for windows https://1127-143324737-gh.circle-artifacts.com/0/devilutionx_x86.exe

For Mac you will have to build it your self.

[AJenbo]

Closing this as there has been no feedback or confirmations for months