Devilutionx: Diablo Hellfire support

[mbreskovec]

Current known issues.

• [x] Barrels and other objects are missing from the hive and crypt.
• [x] Na-Krul doesn't spawn.
• [x] Store menus aren't correct
• [ ] Some instability
• [x] Town doesn't update when opening crypt and hive
• [ ] Runes have no effect
• [ ] Corner Stone of The World doesn't work
• [ ] Not compatible with Hellfire save games
• [ ] The support screen is missing.
• [x] Clicking ESC goes to the support screen instead of Quit Hellfire
• [x] Description for Loopback is that of UDP
• [ ] Griswold will buy random belt items.

See https://github.com/diasurgical/devilution/milestone/4 for further details on what is missing

[AJenbo]

Hi @mbreskovec

We probably will incorporate some of the changes from Hellfire (like map in town). The expansion issn't universally liked (especially not by the original developers). Most likely it will be added as a mod for DevilutionX once we get that going, it would form a pretty good proving grounds for that goal.

As for your question about translation, yes defiantly, i think we will aim for a multilingual program so that users can switch the language instead of the current solutions floating around out there where the exe has been hex edited to a specific language.
The only real limitation here is that the font in Diablo is ISO_8859-1 so there some limitations of how well different languages can be represented.
https://en.wikipedia.org/wiki/ISO/IEC_8859-1#Modern_languages_with_complete_coverage

[mewmew]

Related to this issue, the GoG release now includes Hellfire (as of June 5, 2019): https://www.gog.com/game/diablo

[ghost]

hellfire.exe v1.01 has been completely mapped out in the scalpel repo, surprisingly there were very few functions added/changed. The DRLG code is just a slight hack of the original. Only complex part is all the new code for the missiles.

[mewmew]

hellfire.exe v1.01 has been completely mapped out in the scalpel repo, surprisingly there were very few functions added/changed. The DRLG code is just a slight hack of the original. Only complex part is all the new code for the missiles.

Sounds like a weekend hackathon to me! :)

[AJenbo]

@mewmew I'll come visit you for this one :D

[ghost]

Well then I'll have to show up and crash the party xDDDDDDDDD

[mewmew]

@mewmew I'll come visit you for this one :D

Definitely!!

[mewmew]

Well then I'll have to show up and crash the party xDDDDDDDDD

You are always welcome Andi! <3

[ZaDarkSide]

Well just add a Sponsor button, I will gladly throw in some money for the Hellfire mod support.
Maybe your hackathon will have some beer included.

[mewmew]

Well just add a Sponsor button, I will gladly throw in some money for the Hellfire mod support.

Regarding a sponsor button, this has been discussed before. And to avoid any risk of associating Devilution with monetary gain the option of donations has been decided against. Thanks for the will to help out though!

Maybe your hackathon will have some beer included.

Haha, as the hackathon happens in Sweden we will most likely have tea and a cinnamon bun, proper FIka style!

[cmhobbs]

I'd love to see hellfire support as well and I was going to ask about a donation button, too. I just discovered this project so I wish I could help. I'll see if I can make sense of the source and figure out how it works but this is all very new to me.

Also, thanks a ton for Devilution. It's so nice to be able to revisit Diablo!

[MBeijer]

@mewmew Where in Sweden? ^^

[ghost]

we will most likely have tea and a cinnamon bun, proper FIka style!

Oh, will Hallondricka be included as well? :P

I'll see if I can make sense of the source and figure out how it works but this is all very new to me.

Cool, would be great to have you join the project. Prepare for an addiction that leads to a gloomy fate and be bound by the chains of code archaeology!

I thought about working on Hellfire support. The issue was that a different compiler was used and some structs were dynamically allocated. We can probably ifdef this for the main project and include a separate .DSP for VC 5.10, but then that leaves the issue of being based on 1.04 vs. 1.07. Most of hellfire's code changes were trivial, with the addition of new missiles being the only complex part.

[cmhobbs]

Cool, would be great to have you join the project. Prepare for an addiction that leads to a gloomy fate and be bound by the chains of code archaeology!

No promises but I'm already digging through the codebase. I've only recently picked up C++ for work and I know nothing about how Diablo or Hellfire behave but the source is interesting at least!

[ghost]

@galaxyhaxz I think it would be ok to have hellfire build on 1.09 even if not bin exact, or are you saying that it makes it harder to see what hellfire changed?

[mewmew]

@mewmew Where in Sweden? ^^

Hi @MBeijer!

We are meeting up in Stockholm. If you happen to be close to the area, feel free to join the Devilution Fika Hackathon :)

Cheers,
Robin

[ghost]

it makes it harder to see what hellfire changed?

Yeah basically. Not only do the changes between 1.04 and 1.07 have to be differentiated, but Sierra also released patch 1.01, which addressed many bugs including some that were fixed in 1.07. And it may have been done differently. More look at the code is needed before we decide, but hopefully we can add it to the base project.

EDIT: to clarify, the mechanic and bugfix for Mana shield is different.

We are meeting up in Stockholm

Is it going to be later this year? Not that I can attend sadly, still gotta do the whole 9 month passport thing lol. Would be super edgy though!!

[mewmew]

Is it going to be later this year? Not that I can attend sadly, still gotta do the whole 9 month passport thing lol. Would be super edgy though!!

Yeah, the first of many Fika hackathons is in a few weeks/a month or two :)

[MBeijer]

@mewmew I'm relatively close and I travel to Stockholm pretty often. :) Would be fun to join up for a fika-hackaton!

[AJenbo]

We had a grate second hackathon, 64bit support is now done and the road ahead is more clear. Hellfire support is also well underway!

[mewmew]

@mewmew I'm relatively close and I travel to Stockholm pretty often. :) Would be fun to join up for a fika-hackaton!

We had a grate second hackathon, 64bit support is now done and the road ahead is more clear. Hellfire support is also well underway!

@MBeijer you are most welcome to join future hackathons :) Anders came up the last week to Stockholm and we did a lot of hacking together. This is but one of many fika hackathons we will be hosting :)

[Yorper]

Very excited for this. Thanks for all your hard work guys/girls.

[cpgrant2482]

Just stirring the pot a bit :) Has there been any recent developments on Hellfire support? If it gets added in, I'd love to try it out.

[qndel]

I'd suggest joining discord for staying up to date :D also nice timing haha

[cpgrant2482]

Awesome! Thanks for pointing this out!

[qndel]

https://discord.gg/aQBQdDe
:)

[AJenbo]

Hellfire has now been merged and a menu has been build for it, at this point trying it out is as easy as:

cmake .. -DHELLFIRE=ON
make -j4

https://github.com/diasurgical/devilutionX/pull/876

[AJenbo]

If anyone has some original Hellfire savegames they would be willing to donate then that would be very helpful for testing.

[spitfire]

There you go

single_x.hsv.zip

[AJenbo]

@spitfire any chance you can upload them here on github so i don't have to create a dropbox account :)

[AJenbo]

Any multiplayer saves out there :)

Should be called something like hrinfo_%d.drv

[AJenbo]

[AJenbo]

@spitfire you can now start new games using your existing Hellfire heros. Loading a save game will fail atm, and hellfire spell levels are set to 0. Could you verify the equipment and other hero stats are correct? I can already say that there are some issues with items but need to know what it is supposed to look like before I can easily correct it :)

[spitfire]

@spitfire any chance you can upload them here on github so i don't have to create a dropbox account :)

Already had them on there and couldn't upload them again on mobile. They should be public and not require an account, did they?

@spitfire you can now start new games using your existing Hellfire heros. Loading a save game will fail atm, and hellfire spell levels are set to 0. Could you verify the equipment and other hero stats are correct? I can already say that there are some issues with items but need to know what it is supposed to look like before I can easily correct it :)

You mean I should try to load them in both Hellfire & devilutionX and compare?

[AJenbo]

Yeah i figured it out, one of the buttons didn't require an account. They are on git hub now for future usage.

If you can compare that would be helpful, but just a screen shot of your stats and inventory in hellfire would be a bit help in it self :)

[spitfire]

These are the stats as seen with Hellfire 1.01 I was playing them on:

[AJenbo]

how about ingame so we see the full stats and items :)

[spitfire]

how about ingame so we see the full stats and items :)

[AJenbo]

The secound savegame you attached appears to be of your Spitfire rouge and not the Sledgehammer barbarian, pretty cool hero though :)

[spitfire]

Attaching my characters straight from the game dir:

hsv.zip

[AJenbo]

Looks like most is being loaded correctly, but there are still some issues around items:

[muzena]

@AJenbo
I compile DevilutionX with Hellfire support.
Then I extract "setup_diablo_1.09_hellfire_v2_(30038).exe" file.
I copied diabdat.mpq to /home/user/.local/share/diasurgical/devilution path.
diabdat.mpq extracted files from "setup_diablo_1.09_(27873).exe" and "setup_diablo_1.09_hellfire_v2_(30038).exe" files are the same size 517.5 MB.
setup_diablo_1.09_(27873).exe file has -> 674.9 MB.
setup_diablo_1.09_hellfire_v2_(30038).exe file has -> 850.1 MB.

When I tried to strat hellfire I get error like in this screenshot:

[qndel]

do you have hellfire mpq?

[muzena]

@qndel
I extract "setup_diablo_1.09_hellfire_v2_(30038).exe" file.
I copied diabdat.mpq to /home/user/.local/share/diasurgical/devilution path.
I extracted according to wiki instructions diabdat.mpq file

[spitfire]

Hellfire has its own mpq files you need to copy in addition to diabdat

[muzena]

How do I unpack that file from "setup_diablo_1.09_hellfire_v2_(30038).exe"?

[qndel]

no idea

[spitfire]

How do I unpack that file from "setup_diablo_1.09_hellfire_v2_(30038).exe"?

I don't have the gog version (this is what you have, right?). If you managed to extract it those files should be next to diabdat if your version does include hellfire.

[AJenbo]

How do I unpack that file from "setup_diablo_1.09_hellfire_v2_(30038).exe"?

The exact same way as diabdat.mpq, but replace the file name with the 4 hellfire mpq names.
hellfire.mpq
hfmonk.mpq
hfmusic.mpq
hfvoice.mpq