Devilutionx: Game crashes when opening inventory after picking up specific item(s)

[FelixMoelder]

While it is possible to open the inventory all the time I have the issue, breaking the game when opening the inventory after picking up a "Book of Holy Bold".
After that happened the first time, I started a new run and checked if I can open the inventory in the dungeons. While that was no problem it crashed directly after picking up that book and opening the inventory.

This issue occurred for me playing with a 32bit build on macOS Mojave.

[AJenbo]

Could you please provide a console log from the crash and possibly a save game that makes this easy to replicate?

[FelixMoelder]

Sure!
I just tried it again and created a save directly in front of a book lieing on the floor. That bug seems to affect different (all?) kind of books.
single_0.sv.zip
devilutionX_crashreport.txt

[AJenbo]

Thanks this is very helpful, the log makes it clear that the issue is with rendering red items (higher stats required the the player has), it should be easy enough to solve.

[AJenbo]

This patch should fix the issue:
https://github.com/diasurgical/devilution/pull/657
I will update this issue once it is merged into master, and again once we have merged 32bit Mac.

[FelixMoelder]

Sounds great!
I was able to reach level 13 on macOS without any new issues besides the ones that were already reported.
I might be able to test the patch tomorrow and check if the crashes are solved.

[FelixMoelder]

The patch solves this issue indeed.
Picking up items which the character can not use and opening the inventory is now possible.

[AJenbo]

Thank for testing, that's good hear I'll prioritize getting this merged when ready and then close this issue.

[AJenbo]

It's now in master, now we just need the 32bit Mac part :)