Devilution: [hellfire] OperateL2Door - Please check bin exactness

[Chance4us]

When the code was decompiled, the comparison was not the same.
Please check the assembler code.

[AJenbo]

It's known that it's not bin exact for hellfire: https://github.com/diasurgical/devilution/issues/1397

[Chance4us]

That's why I decompiled it. It looks a little different in the picture above.
Look at the yellow dots. It should be checked whether the changes will lead to bin exactness.

[AJenbo]

If you like we can help you setup the tools so that you can check and make a pull request that makes it bin exact

[Chance4us]

Yes. Thank you. That would be helpful. I'll be asking some questions about the tools soon if that's okay.

[AJenbo]

Definitely. Though it would be easiest via chat, there is even a channel there with a guide for how to get things running for working on Hellfire.

[mewmew]

Happy to see you join us in the reversing efforts @Chance4us :)

[Chance4us]

Thank you also for the effort of all of you guys.
Can anyone describe how I can join the chat channel?

[qndel]

https://discord.gg/MX8VhHu

[Chance4us]

Thank you @qndel

[qndel]

void OperateL2Door(int pnum, int i, DIABOOL sendflag)
{
    int dpx, dpy;

    dpx = abs(object[i]._ox - plr[pnum]._px);
    dpy = abs(object[i]._oy - plr[pnum]._py);
    if (dpx == 1 && dpy <= 1 && object[i]._otype == OBJ_L2LDOOR)
        OperateL2LDoor(pnum, i, sendflag);
    if (dpx <= 1 && dpy == 1 && object[i]._otype == OBJ_L2RDOOR)
        OperateL2RDoor(pnum, i, sendflag);
}

bin exact in this form