Devilution: pack.cpp

[AJenbo]

• [x] 448765 (PackPlayer)
• [x] 448953 (PackItem) #747
• [x] 448A5E (VerifyGoldSeeds)
• [x] 448AD0 (UnPackPlayer)
• [x] 448D48 (UnPackItem)

[AJenbo]

@qndel nice work :D Two files in 24 hours, really nice considering how long it is since last we finished any files.

[mewmew]

PackItem no longer bin exact?

Edit: is that the one with the nop instruction? :p

[qndel]

PackItem no longer bin exact?

Edit: is that the one with the nop instruction? :p

yup 📦

[mewmew]

PackItem no longer bin exact?
Edit: is that the one with the nop instruction? :p

yup :package:

@AJenbo, calling that minimal differences. I don't know. Seems quite major to me.

[AJenbo]

@mewmew yeah I'm a bit torn by it after looking at it in IDA, I will try with a hex editor next, though I'm not sure what exactly is going on.

[AJenbo]

Fixed

[mewmew]

Fixed

What was the fix??

[qndel]

Fixed

What was the fix??

changing stuff to unsigned :P

[AJenbo]

@mewmew this PR: https://github.com/diasurgical/devilution/pull/752 had to change 50 lines to fix one byte :roll_eyes:

[mewmew]

@mewmew this PR: #752 had to change 50 lines to fix one byte :roll_eyes:

Haha, that's dedication to fix a nop :p

[sskras]

You guys are seriously serious.