Devdocs: 404 Links in /guides/v2.2/contributor-guide/contributing.html

[manishmittalm]

Bug report

404 Links in /guides/v2.2/contributor-guide/contributing.html

Description

Many 404 Links I found in this document /guides/v2.2/contributor-guide/contributing.html, they should redirect to proper URL instead 404.

Steps to reproduce

1. Open in browser https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html
2. Search "Community Maintainers", "Magento EngCom Team" link
3. Click on these link they will redirect to 404 page

Expected result

They should redirect to proper url instead 404

[shrielenee]

Hi @manishmittalm - I checked those links on my browser and an Incognito window and received no 404s. What browser are you using?

[manishmittalm]

Hello @shrielenee

I am using Ubuntu > Google Chrome.

Trying to access these pages directly:

https://github.com/orgs/magento/teams/core-maintainers/members
https://github.com/orgs/magento/teams/open-source-maintainers/members

[jeff-matthews]

I believe that you must have access to a GitHub org to see the teams associated with that org. GitHub doesn't do a good job indicating you don't have access on their error page.

[manishmittalm]

Thanks, Jeff, can you please guide how can I access now.

[jeff-matthews]

If you create a pull request for this repo, you'll automatically receive an invitation to join the ~maintainers~ contributors team, which is part of the Magento org. After accepting the invitation, you should be able to access these links.

[shrielenee]

Did that work for you @manishmittalm? If so, I'll close this issue! Thanks for taking the time to submit it. 🏆

[bhargavmehta]

Hello @shrielenee can we replace the maintainers link with https://magento.com/magento-contributors#/community-maintainers which is a better option and maintained on Magento Website?
If so I'll create a PR for the same.

Thank you

[manishmittalm]

Hello @jeff-matthews Can you please share a link of the repo to create a pull request. Thanks for the help and one more suggestion if we have to make a pull request for this repo then that should be mention therein guidance so that will be helpful to other users.

[manishmittalm]

Did that work for you @manishmittalm? If so, I'll close this issue! Thanks for taking the time to submit it.

Thanks @shrielenee but still facing issue.

[jeff-matthews]

@manishmittalm, it's _this_ repo: https://github.com/magento/devdocs

[shrielenee]

@bhargavmehta You want to change the Maintainers link in the left sidebar on this page https://devdocs.magento.com/guides/v2.2/contributor-guide/maintainers.html to https://magento.com/magento-contributors#/community-maintainers ?

The way it's currently linked is appropriate, as the page we send users to includes the link to the Contributors page you mentioned, along with a wealth of other relevant info. I'd like to leave it as-is for now. Thanks!

[bhargavmehta]

Hello @shrielenee ,

I was talking of the line "To deploy, Community Maintainers, a Magento EngCom Team member, or contributor under the existing Pull Request enters the following command as a comment to the pull request:" in the attached screenshot. But I guess its correct right now and dont need any change. As that page will appear after someone does a PR.
Thank you

[shrielenee]

Hey @manishmittalm - I'm going to go ahead and close this issue, as it seems you now have a better idea where to create a PR for this! Thanks so much for taking the time to report an issue!