Desktop: Merge request #1379 removes ability to start hidden to tray.

Created on 5 Nov 2020  路  5Comments  路  Source: mattermost/desktop

I confirm (by marking "x" in the [ ] below: [x]):


Summary
Merge request #1379 removes ability to autostart desktop app hidden by default.
Also flag --hidden doesn't work.

Environment

  • Operating System: Archlinux
  • Mattermost Desktop App version: 4.6.1
  • Mattermost Server version: 5.27.0

Steps to reproduce
Update from 4.5.3 to 4.6.*

Expected behavior
Application will launch collapsed into tray.

Observed behavior
Application show window by default.

Possible fixes

Revert #1379 or revert command line flag to preserve old behavior.

All 5 comments

hello and thanks for reporting, but that was the actual expected behaviour of that PR, it was decided that starting minimized was a confusing experience for most people.

Maybe you can revert --hidden flag for people who want app to start minimized?

@AKorezin thanks for the feedback. I've opened a ticket to make the behaviour on launch configurable. Let us know if you're interested in taking it! https://mattermost.atlassian.net/browse/MM-30336

@esethna it'll be a nice feature.

As for me I autolaunch the app at boot time and autoclose it on shutdown. So most of time it runs in the background.
Most of my apps have this feature.
Some apps like steam has console flag to start minimized.
Some apps like thunderbird has no tray support, but have mods or hacks like birdtray.

Update: used PKGBUILD from aur with reverted patch #1379.
wget https://patch-diff.githubusercontent.com/raw/mattermost/desktop/pull/1379.diff -O 1379_hide_on_startup.patch

diff --git a/PKGBUILD b/PKGBUILD
index 8bac9df..b5fdd71 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -16,14 +16,18 @@ makedepends=('git' 'jq' 'npm')
 #optdepends=('hunspell: spell checking')
 source=("$pkgname-$pkgver.tar.gz::$url/archive/v$pkgver.tar.gz"
         "$pkgname.sh"
-        "${pkgname/-/.}")
+        "${pkgname/-/.}"
+        "1379_hide_on_startup.patch")
 sha256sums=('620ff64ec2c04bfe1005c25988a5d4cb20e376bc9dca9e3ce3e11dbd59ad0b47'
             '0f18f87764465f1fc5a9fdfb6ef2834af4623c13bc95fce58da6cb0d8d39a75e'
-            'e628268d3393aac0d5b7237c6b8818d2e362c373f99874a19171bf96a25e4ffa')
+            'e628268d3393aac0d5b7237c6b8818d2e362c373f99874a19171bf96a25e4ffa'
+            '43ed02e97adfa8b667c7f77b82a8ec1041e8855768a8c965332655fe057f5e2d')

 prepare() {
     cd "desktop-$pkgver"

+    patch --reverse --strip=1 --input="${srcdir}/1379_hide_on_startup.patch"
+
     # Depending on the architecture, in order to accelerate the build process,
     # removes the compilation of ia32 or x64 build.
     if [[ "$CARCH" == x86_64 ]];then

Works ok for me.

Was this page helpful?
0 / 5 - 0 ratings