Desktop: White background in recipient list

Created on 7 Oct 2019  Â·  6Comments  Â·  Source: nextcloud/desktop

See white background in recipient list

image

bug design

Most helpful comment

@jancborchardt yeah I know about this, generally I list relating issues like that in the PR, then they are automatically resolved when merging - just didn‘t know about this one.
I‘ll fix the conflict blocking the PR merge within this week

All 6 comments

This is fixed in the pull request at https://github.com/nextcloud/desktop/pull/1429 :)

Not sure how you do this in other repos, but in Android we keep issues open until PR is merged (and in PR we use "fix #123123123" so that Github auto closes this).
This ensures that other reporters can more easily find the issue (as it is technically not yet solved).

Yep, we normally do that too, but since https://github.com/nextcloud/desktop/pull/1429 does not have a reference to this here, I closed it so we don’t have to clean up afterwards. I should have mentioned that, sorry. :)

@DominiqueFuchs you probably know if you include "…, fix #1429" in a commit it closes the issue automatically on merge? :)

It does not necessarily have to be in a commit, you can just put in the PR description (it just has to be the first line(s))

@jancborchardt yeah I know about this, generally I list relating issues like that in the PR, then they are automatically resolved when merging - just didn‘t know about this one.
I‘ll fix the conflict blocking the PR merge within this week

FTR: Merged #1429 🎃

Was this page helpful?
0 / 5 - 0 ratings

Related issues

nilsbecker picture nilsbecker  Â·  3Comments

linucksrox picture linucksrox  Â·  3Comments

AndreyNazarchuk picture AndreyNazarchuk  Â·  4Comments

kaysond picture kaysond  Â·  3Comments

js-d-coder picture js-d-coder  Â·  3Comments