Desktop: Make Application Icon use SVG

[mcnesium]

Compared to other Icons the Mattermost icon looks pretty pixely in the Gnome 3 application switcher. It also does so in the dock. This is propably due to a poor scaling algorithm of the PNG used as the application icon.

So this is a feature request to use SVG for the application icon at least on capable operating systems.

[jasonblais]

@yuya-oc are we able to use an SVG icon for the app icon? Or should we use a higher-quality PNG instead?

I agree it does look pixelated compared to others

[yuya-oc]

For now I'm not sure how SVG is applied on Gnome.

@mcnesium For reference, would you tell the distribution and the way to install you are using?

[mcnesium]

Of course, sorry. This is on Manjaro Gnome 17.0 with GNOME Shell 3.22.3 and Mattermost 3.6.0 installed from AUR

[duniul]

This bothered me as well, the default icon looks very pixelated when using dash-to-dock for Gnome or Budgie. It also opens a separate icon if you have mattermost pinned as favorite instead of using the same one. The reason for this seems to be that the desktop entry mattermost-desktop.desktop doesn't match the WMCLASS of the application ("mattermost", "Mattermost").

Incorrect icons using default mattermost-desktop.desktop
Correct icons using renamed mattermost.desktop

Renaming the desktop entry solved the problem for me. Would it perhaps be possible to either rename the .desktop filename it installs or change the WMCLASS? I have only tried this on Gnome with dash-to-dock and Budgie, but I assume this would solve the issue for other launchers as well.

[jasonblais]

@yuya-oc thoughts on renaming the desktop entry? Would there be potential consequences of the change?

[j1mc]

Only noting this as an issue with Ubuntu 18.04, as well. I never noticed it as an issue while using Ubuntu+Unity, but the pixelation stands-out quite a bit more in GNOME Shell.

I've confirmed this on the newly-released mattermost-desktop version 4.1.0.

[j1mc]

I'll be submitting a patch which adds an SVG icon. Here's the before:

And here's the after:

Expect this patch in the next day or so.

[jasonblais]

Awesome, thanks @j1mc!

[j1mc]

Pull request submitted here

[skewty]

I think there has been some sort of regression because I have an ugly icon.
Ubuntu 19.04 with Mattermost 4.2.1