Is this a good time to refactor this to use globalThis which has been supported since v8 v7.1?
https://github.com/denoland/deno/blob/d68b44b6b2fad6c321aa01a039030bb98c5be88d/js/window.ts#L7
motss
👍6
All 3 comments
There were some issues in earlier versions of v8 when snapshotting where globalThis wasn't available... I never was able to isolate it, but that is what prevented the refactor before (I tried it). That may have been addressed now. Worth trying again.
kitsonk
on 26 Apr 2019
👍2
@kitsonk I'll take it and see what happens.
motss
on 26 Apr 2019
👍1
Closing this for now as the same issues happen.
motss
on 27 Apr 2019
Was this page helpful?
0 / 5 - 0 ratings
Related issues
ry
路
3Comments
xueqingxiao
路
3Comments
kitsonk
路
3Comments
amiteshore
路
3Comments
ry
路
3Comments
Most helpful comment
There were some issues in earlier versions of v8 when snapshotting where
globalThiswasn't available... I never was able to isolate it, but that is what prevented the refactor before (I tried it). That may have been addressed now. Worth trying again.