As noted as a TODO item in 0d03fafbfec4545098023b7147c5f8fb6ae06f99, the current way we're implementing async FS ops is still blocking. We have to call tokio_threadpool::blocking like tokio-fs does.
Example: https://github.com/tokio-rs/tokio/blob/0f44adf5f696ac73dcdcb1fb2b91b87553c57443/tokio-fs/src/rename.rs#L52
Fixing this should not involve touching JS code.
is there any reason that we can't use tokio-fs itself?
@sijad Once #782 lands we'll be able to use tokio-fs
Fixed in df09fbad92c4d48e58ed34000000f01ec4812e48
Most helpful comment
is there any reason that we can't use tokio-fs itself?