Dbatools: [Bug] Update-DbaInstance trying to extract to path name too long

[garethnewman]

[Invoke-DbaAdvancedUpdate] Extraction failed with exit code 16389

The command is detecting our sqlclone VHDs as a suitable large disk to copy and extract the file to. The issue here being the path to our sql clone VHDs is quite long, too long to extract the update to.

Can we tell it to ignore sql clone disks AND/OR specify the path e.g. "C:updates"

I believe default naming is "SqlClone_VhdMount" e.g.

SqlClone_VhdMountdbatools_KB4488536_Extract_f5ee5e8fe25e4a949f74e5bab470f18a

Thanks,

[garethnewman]

want me to pick this up @nvarscar ? my proposed fix would be to catch any error extracting or copying the file and then revert back to the system as you have everything in place for that already so that should be a quick fix that I could manage, I think...maybe :+1:

So what it currently does is:

do I have a location for this file? Yes --> extract in that location
do I have a location for this file? No --> extract in system

So I propose:

Do I have a place for this file -->Yes --> Start extracting
Did the extraction fail? Yes--> Revert to system drive and try again.

[nvarscar]

I'm thinking that -ExtractPath parameter should also be a thing at this point. If you're comfortable with implementing both - go for it!

[garethnewman]

I'll give it a try, thanks.