Dbatools: DbaServer Rename

[potatoqualitee]

The name never sat right with me. I'd like to change a few of these

ServerAudit -> Audit and then make a DbAudit <-- for sure
ServerAuditSpecificiation -> Audit and then make a DbAuditSpecificiation <-- for sure
ServerTrigger -> Trigger. DbTrigger already exists <-- questionable
ServerRole -> Role, then make a DbRole
ServerRoleMember -> RoleMember. DbRoleMember already exists

[csolje]

The Names reflects pretty good with what the same feature is called on the Sql Server

[potatoqualitee]

i'd still like to go forward but it turns out there are breaking changes so going to put this on hold till closer to 1.0

[shaneis]

Isn't there an inherent difference between ServerTrigger & ServerRole and DbTrigger & DbRole i.e. the former being server based and the latter being database based?

To distinguish the difference, you'd need something like Server in there, or maybe Srv for brevity.

I was going to suggest adding a switch parameter -Server if you want to do something server based but I'd say that's too hidden away so wouldn't be discover-able enough for PowerShell.

[potatoqualitee]

yeah, they are there for legit reasons. i guess im just iffy on the word Server? Should it be Instance? But they are called Server in SMO i think

[potatoqualitee]

and thank you!

[NakedPowerShell]

I believe that whatever you pick will be the right choice. So I can live with either Server or Instance

[garethnewman]

I prefer Instance but can live with either :)

[potatoqualitee]

thank you all, i think im leaning instance since server never sat right ❤️

[NakedPowerShell]

To ship is to choose :}

[potatoqualitee]

k going instance, doing this now