Datadog-agent: The environment variables DD_AC_EXCLUDE and DD_AC_INCLUDE don't seem to do anything.

[nimeshksingh]

Output of the info page (if this is a bug)

oot@datadog-uds-datadog-56h6p:~# agent status
Getting the status from the agent.

==============
Agent (v6.1.2)
==============

  Status date: 2018-04-11 01:23:40.194806 UTC
  Pid: 348
  Python Version: 2.7.14
  Logs: 
  Check Runners: 1
  Log Level: WARNING

  Paths
  =====
    Config File: /etc/datadog-agent/datadog.yaml
    conf.d: /etc/datadog-agent/conf.d
    checks.d: /etc/datadog-agent/checks.d

  Clocks
  ======
    NTP offset: 0.005637099 s
    System UTC time: 2018-04-11 01:23:40.194806 UTC

  Host Info
  =========
    bootTime: 2018-03-21 17:00:18.000000 UTC
    kernelVersion: 4.4.111+
    os: linux
    platform: debian
    platformFamily: debian
    platformVersion: 9.4
    procs: 70
    uptime: 1.757842e+06

  Hostnames
  =========
    host_aliases: [gke-lightstep-staging-pool-2-2fbff9bc-409k.helpful-cat-109717]
    hostname: gke-lightstep-staging-pool-2-2fbff9bc-409k.c.helpful-cat-109717.internal
    socket-fqdn: datadog-uds-datadog-56h6p
    socket-hostname: datadog-uds-datadog-56h6p

=========
Collector
=========

  Running Checks
  ==============
    cpu
    ---
      Total Runs: 23
      Metrics: 6, Total Metrics: 132
      Events: 0, Total Events: 0
      Service Checks: 0, Total Service Checks: 0

    disk
    ----
      Total Runs: 23
      Metrics: 154, Total Metrics: 3542
      Events: 0, Total Events: 0
      Service Checks: 0, Total Service Checks: 0

    docker
    ------
      Total Runs: 23
      Metrics: 121, Total Metrics: 2783
      Events: 0, Total Events: 1
      Service Checks: 1, Total Service Checks: 23

    file_handle
    -----------
      Total Runs: 23
      Metrics: 1, Total Metrics: 23
      Events: 0, Total Events: 0
      Service Checks: 0, Total Service Checks: 0

    io
    --
      Total Runs: 23
      Metrics: 130, Total Metrics: 2900
      Events: 0, Total Events: 0
      Service Checks: 0, Total Service Checks: 0

    kubelet
    -------
      Total Runs: 23
      Metrics: 212, Total Metrics: 4869
      Events: 0, Total Events: 0
      Service Checks: 3, Total Service Checks: 69

    kubernetes_apiserver
    --------------------
      Total Runs: 23
      Metrics: 0, Total Metrics: 0
      Events: 0, Total Events: 0
      Service Checks: 0, Total Service Checks: 0

    load
    ----
      Total Runs: 23
      Metrics: 6, Total Metrics: 138
      Events: 0, Total Events: 0
      Service Checks: 0, Total Service Checks: 0

    memory
    ------
      Total Runs: 23
      Metrics: 14, Total Metrics: 322
      Events: 0, Total Events: 0
      Service Checks: 0, Total Service Checks: 0

    network
    -------
      Total Runs: 23
      Metrics: 56, Total Metrics: 1288
      Events: 0, Total Events: 0
      Service Checks: 0, Total Service Checks: 0

    ntp
    ---
      Total Runs: 23
      Metrics: 1, Total Metrics: 23
      Events: 0, Total Events: 0
      Service Checks: 1, Total Service Checks: 23

    uptime
    ------
      Total Runs: 23
      Metrics: 1, Total Metrics: 23
      Events: 0, Total Events: 0
      Service Checks: 0, Total Service Checks: 0

========
JMXFetch
========

  Initialized checks
  ==================
    no checks

  Failed checks
  =============
    no checks

=========
Forwarder
=========

  CheckRunsV1: 24
  IntakeV1: 4
  RetryQueueSize: 0
  Success: 52
  TimeseriesV1: 24

  API Keys status
  ===============
    https://6-1-2-app.agent.datadoghq.com,*************************a39e7: API Key valid

==========
Logs Agent
==========

  Logs Agent is not running

=========
DogStatsD
=========

  Checks Metric Sample: 16571
  Event: 2
  Events Flushed: 2
  Number Of Flushes: 24
  Series Flushed: 62075
  Service Check: 391
  Service Checks Flushed: 415
  Dogstatsd Metric Sample: 517304

Describe what happened:
I set these environment variables:
DD_AC_EXCLUDE = '["image:.*"]'
DD_AC_INCLUDE = '["image:cp-kafka", "image:k8szk"]'

But that seemed to have no impact on what metrics are collected.

(I got the format from a datadog.conf.example.)

Describe what you expected:
Metrics collection would be disabled for all containers except cp-kafka and k8szk as described here: https://github.com/DataDog/datadog-agent/tree/master/Dockerfiles/agent#ignore-containers

Steps to reproduce the issue:

1. set the env variables DD_AC_EXCLUDE and DD_AC_INCLUDE
2. run datadog-agent

Additional environment details (Operating System, Cloud provider, etc):
Kubernetes 1.8, datadog-agent jmx docker image, GKE

[xvello]

Hello @nimeshksingh

The library we use for parsing environment variables handles []string values as space separated values, not inline json like maps. Can you please try the following values:

DD_AC_EXCLUDE = "image:.*"
DD_AC_INCLUDE = "image:cp-kafka image:k8szk"

I'll update the documentation accordingly after you confirm this works for you.

[nimeshksingh]

This worked. Thanks!

[xvello]

Sorry for the confusion, we updated the documentation accordingly.

Closing the issue

[maxfriedmann]

The documentation is unclear about the keys that can be used, are there more options than name and image?

Also, is the string a regex? If yes, what kind of regex parser is being used? I want to exclude all containers that have an image name starting with rancher/, so e.g. rancher/net, rancher/metadata and so on, but this doesn't seem to work:

DC_AC_EXCLUDE = "image:rancher/.*"