Dashboard: Cannot search step logs

[jbarrick-mesosphere]

Expected behavior

When I press control + F when browsing step logs, I should be able to search over the whole log.

Actual behavior

Control + F can only search over the logs in the current view.

[AlanGreene]

Thanks for raising this, it's a request we've had from other users too and I agree that this would be great to have. The current implementation only renders the visible lines (plus a small buffer either side) for performance reasons based on feedback from a number of users with very large logs.

For now, you can download the logs by clicking the button in the upper right corner of the log container and search locally (not ideal I know). This is available in the latest nightly builds.

[jbarrick-mesosphere]

Thanks!

We could add another button that loads the raw logs in a tab (instead of downloading)? That way the user can click into it (without needing to open a text editor) easily. I've had good luck with that on other CI systems.

[AlanGreene]

Great suggestion, PR here: https://github.com/tektoncd/dashboard/pull/1076

[jbarrick-mesosphere]

Awesome, thank you!

[AlanGreene]

PR open to render full logs up to 20k lines, after which we revert to the current virtualized list behaviour.

This should be sufficient for most users, re-enabling the browser-native 'find in page' (ctrl/cmd-f) functionality, and we still have the ability to open the logs in a new tab or download to search locally if required for very large logs.

[justinbarrick]

Very cool 😎