Darkreader: [BUG] github.com flashes on firefox

Created on 22 May 2020  路  3Comments  路  Source: darkreader/darkreader

Describe the bug
The bug here is that when loading the page a huge X sign flashes for a second.

To Reproduce
Steps to reproduce the behavior:

Install Dark Reader on firefox.
Open the Dark Reader repository.
Reload the page
The page bugs out while the dom is loading.

Expected behavior
The huge X sign should not flash when the dom is loading.

Screenshots
https://streamable.com/efe935

System Information:

  • OS: Windows
  • Browser Firefox
  • Version 76.0.1

Additional context
The issue occurs only on firefox for me, I couldn't replicate the issue on brave.

bug

Most helpful comment

Hmm, I always thought Firefox did that but seems like it's not.
I only know that could cause this is our throtlle function that will call functions a bit later to not crash your pc :) I will see if I can do something for this, but also Github normal CSS should be affected when the DOM is loaded.

All 3 comments

Github or Firefox loads the CSS later than the HTML first paint :) If you remove Dark reader and refresh without cache you will get the same behaviour

That doesn't seem to be the case.
https://streamable.com/bcsvpe
I tried it with cache disabled and without Dark Reader. It doesn't seem to flash.

Hmm, I always thought Firefox did that but seems like it's not.
I only know that could cause this is our throtlle function that will call functions a bit later to not crash your pc :) I will see if I can do something for this, but also Github normal CSS should be affected when the DOM is loaded.

Was this page helpful?
0 / 5 - 0 ratings