Cypress-file-upload: [Feature] Upgrade to Cypress 4

Created on 8 Feb 2020  ยท  4Comments  ยท  Source: abramenal/cypress-file-upload

Current behavior:

This plugin requires Cypress 3.x.x according to https://github.com/abramenal/cypress-file-upload/blob/9df046cc78db802a0943d9dac82bbd60be029072/package.json#L45.

Desired behavior:

I wish the plugin is updated to work with the current version of Cypress, which is 4.0.1.

Thanks for a great plugin! ๐Ÿ‘‹

enhancement

Most helpful comment

Hi @warpech
Thanks for submitting the issue!

I am really happy that the plugin went so widely used among the community ๐Ÿ˜ƒ
With regards to new version I expect a bunch of issues either related to v4 itself or cross-browser compatibility (like #154)

So I would expect having proper tests and fixing all ongoing issues until the end of February.

Stay tuned! ๐ŸŒŸ

All 4 comments

Hi @warpech
Thanks for submitting the issue!

I am really happy that the plugin went so widely used among the community ๐Ÿ˜ƒ
With regards to new version I expect a bunch of issues either related to v4 itself or cross-browser compatibility (like #154)

So I would expect having proper tests and fixing all ongoing issues until the end of February.

Stay tuned! ๐ŸŒŸ

For us, all of our tests, including the ones that used cypress-file-upload to upload an image to a form using https://www.dropzonejs.com/, worked flawlessly with Firefox and Cypress v4 :relaxed:

We merely ignore the warning generated by the peer dependency requirement of cypress-file-upload for now

Given I have:

  • yarn version 1.21.1;
  • cypress-file-upload version 3.5.3;
  • cypress version 4.0.2.

When I run yarn install

Then this is Terminal output:

[1/5] ๐Ÿ”  Validating package.json...
[2/5] ๐Ÿ”  Resolving packages...
[3/5] ๐Ÿšš  Fetching packages...
[4/5] ๐Ÿ”—  Linking dependencies...
warning " > [email protected]" has incorrect peer dependency "cypress@^3.0.0".
[5/5] ๐Ÿ”จ  Building fresh packages...

success Saved lockfile.
โœจ  Done in 21.57s.

Process finished with exit code 0

But this should be the Terminal output:

[1/5] ๐Ÿ”  Validating package.json...
[2/5] ๐Ÿ”  Resolving packages...
[3/5] ๐Ÿšš  Fetching packages...
[4/5] ๐Ÿ”—  Linking dependencies...
[5/5] ๐Ÿ”จ  Building fresh packages...

success Saved lockfile.
โœจ  Done in [...]s.

Process finished with exit code 0

For now I'm ignoring the warning (like @valscion said)...
...but it would be better if this warning does not appear.

Hi @warpech @valscion @jimmyandrade,
it's now fixed with v4 release, please check out!

Cheers!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

thiagobrez picture thiagobrez  ยท  8Comments

harrison9149 picture harrison9149  ยท  7Comments

skjnldsv picture skjnldsv  ยท  5Comments

skjnldsv picture skjnldsv  ยท  5Comments

nathanielongyiitak picture nathanielongyiitak  ยท  4Comments