Cxbx-reloaded: bisect turok

[PatrickvL]

Turok menus regressed - bisect and report findings here

[Paradise12314]

I'm not sure what type of Regression you have on Turok, but I've had serious graphical corruption since a Commit back in February.

On Appveyor, it's called "GetVertexBufferSize wasn't taking offset into account: This fixes Zapper!"

The Videos play fine, but almost all the Menu is Black, running at around 4fps and also makes my Desktop flicker like crazy. It is the same from that one right up to the latest version. It was fine and mega fast before that Commit.

Specs:
i5 2500 3.3Ghz
8gb Dual Channel DDR2
512mb 9500gt DDR2 Driver 341.44

If your wondering why such a bad Card with that CPU, I did have a GTX 560ti till it died, leaving me with this old Relic lol.

Video playing fine:

Bad Commit Menu:

Previous Good Commit Menu:

[PatrickvL]

Thanks for digging into this! Am I correct assuming the is the culprit ? https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/commit/151c5963bae96adff0c880799b17f3af400bcc43

[Paradise12314]

Yes that's the one. I'm confused though. JohnGoodGames used a more recent version than that, and it's fine. His Video is on YouTube. He uses a GTX 1080 though. Perhaps 151c596 broken old DX10 Cards only?

[PatrickvL]

I can't verify your findings - for me the menu has been corrupted much longer. I'm doing a bisect too...

[jarupxx]

I use GTX 750ti works up to PR 954, perhaps PR https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/pull/956 broken.

PR 956 broken

PR 954

[PatrickvL]

Thanks. Let's see if others can reproduce that too..

[PatrickvL]

@LukeUsher If indeed #956 broke Turok menus, then perhaps that's due to the removal of the StateBlock patches?

[JohnGodgames]

100% comes from PR https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/pull/956

[PatrickvL]

Luke is working on this - his result looked like this a few days ago :

[LukeUsher]

Turok regressed when we switched over to the Dxbx based pixel shader conversion. The issue is related to when titles use RenderState/TextureState functions to modify the shader.

Fixing this functionality restores Turok, but breaks JSRF.

Maybe we need to port the RenderState code from WIP_LessVertexPatching so we can remove those patches and read from the D3D state directly.

[PatrickvL]

I can confirm it's rendering correctly again - but I'm not entirely sure which commit actually fixed it...

EDIT: It might be fixed thanks to this : https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/pull/1216