Cwa-app-ios: [Fix 1.12] Translation issue: Wrong text in version 1.11 if no exposures are detected (all languages but German)

[Ein-Tim]

Avoid duplicates

• [x] Bug is not mentioned in the FAQ
• [x] Bug is not already reported in another issue

Technical details

• Device name: iPhone 6s & iPhone XR
• iOS Version: 14.4
• App Version: 1.11.0

Describe the bug

Version 1.11 of the Corona-Warn-App is showing "Exposure with low risk on 0 days" (in all languages but German).

Steps to reproduce the issue

1. Set f.e. English as language
2. Open CWA
3. See wrong text on home screen

Expected behaviour

The text should be, like the German text, "No exposures" in the respective languages.

Possible Fix

Change the text

Additional context

Screenshots:

German:

English:

---

Internal Tracking ID: EXPOSUREAPP-4893

[dsarkar]

Internal Tracking ID: EXPOSUREAPP-4893

[Ein-Tim]

@dsarkar did you check the behavior under Android?

Edit: @MikeMcC399 could you check Android please?

[cricketsamya]

What does this mean actually? I am seeing this since morning!

[Ein-Tim]

@cricketsamya

This means that everything is ok, no exposures have been recorded.

[MikeMcC399]

@Ein-Tim

@dsarkar did you check the behavior under Android?

Edit: @MikeMcC399 could you check Android please?

I can't see any problem in CWA Android 1.11.0
The text in English is "No exposures", corresponding to the German "Keine Risiko-Begegnungen".

[ndegendogo]

@cricketsamya what exactly confused / worried you?
Was it the text 'Confirmed New Infections' at the bottom of your screenshot?

Actually, I can imagine that some users could misunderstand this text and think that they have a confirmed infection.
Maybe this statistics should better be moved to a separate card with a clear title?

[cricketsamya]

@ndegendogo Exposures with low risk on zero days is a wrong translation.

Second the cards for the stats may be can moved to a stats screen??

[ndegendogo]

@cricketsamya

Exposures with low risk on zero days is a wrong translation.

Sure, you are right.

Second the cards for the stats may be can moved to a stats screen??

Exactly this was my thought when I saw your screenshot. imo it can be easily misunderstood.
(I just wanted a second opinion on this, thanks!)

[OliverRM]

Looks like the bug is in file _cwa-app-ios/src/xcode/ENA/ENA/Resources/Localization/XX.lproj/Localizable.stringsdict_, key _Home_Risk_Low_Number_Contacts_Item_Title_.

Commit 0f22dc changed <string>No exposures</string> to <string>Exposures with low risk on %u days</string>. For english language this change was reverted in commit 71e73a.

Anyway, commit 71e73a only addressed English language. Furthermore commit 0f22dc made further changes in _Localizable.stringsdict_ that look suspicious to me:

• <string>Update in %02u:%2$#@seconds@ seconds</string> changed to <string>Update in %02u:%2$#@seconds@ minutes</string>
• <string>Exposure logging has been active for less than one day. An exposure check can only be reliable if exposure logging is permanently activated.</string> changed to <string>Exposure logging has been active for %u days. An exposure check can only be reliable if exposure logging is permanently activated.</string>

Can someone please review entire commit 0f22dc?

[dsarkar]

@OliverRM Thanks, forwarded info to devs.

[Ein-Tim]

Thanks from my side too @OliverRM.
So seems like at least for English the fix https://github.com/corona-warn-app/cwa-app-ios/commit/71e73ad503fb6fdb0fa4610e4953de39b495471f is included in this PR which is merged into the release 1.12.x branch.
I will keep on monitoring the incoming translation deliveries to see if they fix this for the other languages too (still it would be nice if @dsarkar could keep us in the loop here 🙂)

[dsarkar]

@Ein-Tim Sure, trying my best to keep you and the community in the loop! ;-)

[Ein-Tim]

1910 Fixes this, I will leave this issue open until the changes are live (version 1.12).

@dsarkar Could you label this Fix 1.12.

Thank you 👍

Edit: FYI version 1.12 will be released on 10.02.21.

[Ein-Tim]

@OliverRM

Regarding your comment about commit https://github.com/corona-warn-app/cwa-app-ios/commit/0f22dc1f58ed6cb5a18e998ae1574a445b9ce015, the changes which were pointed out by you will be reverted (#1916), for the quoted English change see this.

Thanks for your help here!

[OliverRM]

Looks good, as far as I can see all changes of 0f22dc1 I pointed out have been reverted. That leaves only one question open:

Looking at the following section of Localizable.stringsdict

    <key>Home_Risk_Status_Counter_Label</key>
    <dict>
        <key>NSStringLocalizedFormatKey</key>
        <string>%#@minutes@%#</string>
        <key>minutes</key>
        <dict>
            <key>NSStringFormatSpecTypeKey</key>
            <string>NSStringPluralRuleType</string>
            <key>NSStringFormatValueTypeKey</key>
            <string>u</string>
            <key>zero</key>
            <!--Plural form for ZERO.-->
            <string>Update in %02u:%2$#@seconds@ seconds</string> <!-- HERE -->
            <key>one</key>
            <!--Plural form for ONE.-->
            <string>Update in %02u:%2$#@seconds@ minute</string>
            <key>few</key>
            <!--Plural form for FEW.-->
            <string>Update in %02u:%2$#@seconds@ minutes</string>
            <key>many</key>
            <!--Plural form for MANY.-->
            <string>Update in %02u:%2$#@seconds@ minutes</string>
            <key>two</key>
            <!--Plural form for TWO.-->
            <string>Update in %02u:%2$#@seconds@ minutes</string>
            <key>other</key>
            <!--Plural form for OTHER.-->
            <string>Update in %02u:%2$#@seconds@ minutes</string>
        </dict>
        <key>seconds</key>
        <dict>
            <key>NSStringFormatSpecTypeKey</key>
            <string>NSStringPluralRuleType</string>
            <key>NSStringFormatValueTypeKey</key>
            <string>u</string>
            <key>one</key>
            <!--Plural form for ONE.-->
            <string>%02u</string>
            <key>zero</key>
            <!--Plural form for ZERO.-->
            <string>%02u</string>
            <key>few</key>
            <!--Plural form for FEW.-->
            <string>%02u</string>
            <key>many</key>
            <!--Plural form for MANY.-->
            <string>%02u</string>
            <key>two</key>
            <!--Plural form for TWO.-->
            <string>%02u</string>
            <key>other</key>
            <!--Plural form for OTHER.-->
            <string>%02u</string>
        </dict>
    </dict>

Commit 0f22dc1 changed seconds to minutes in line <!-- HERE -->. c4f6c61 reverted this change.

First I thought it should be seconds as the variable is called seconds. That is why I pointed it out in my comment. But then the following lines should be seconds two. Only now I realised that it all belongs to the key minutes. Maybe it actually was right to change it to minutes? Or should it not actually be something like Update now?

Same applies to other languages. German wasn't affected by the commits but same questions apply.

[Ein-Tim]

Can confirm that this has been fixed in 1.12.1:

[Ein-Tim]

I will close this now, @OliverRM please open a new issue if you see any wrong text in version 1.12.1.

Thanks!

[dsarkar]

@Ein-Tim Thanks!

[cricketsamya]

Shows the message as expected! 👍🏼