Curriculum: Style Guide link shows #404 ERROR

[Tawishi]

The Style Guide link in the below image leads to #404 error.

[vegetabill]

@Tawishi thanks for taking the time to capture this error. Can you include a URL where your image came from?

[Tawishi]

@Tawishi thanks for taking the time to capture this error. Can you include a URL where your image came from?

Yes. Here it is.
https://github.com/Techtonica/curriculum/blob/master/_templates/instructions.md

[alodahl]

I see - this should be https://github.com/Techtonica/curriculum/tree/master/_templates#instructions

@Tawishi I think Bill is trying to ask, what page was the broken link in?

[vegetabill]

@Tawishi I meant the page where that link is used, not the 404 link.

By searching the text in your image above, I found the page: /CONTRIBUTING.md

It should be updated to point to _templates/ so it will show the README

[vegetabill]

@Tawishi since you are still working on #1189 I will leave this unassigned for 7 days so you can have the opportunity to work on it since you created it. After that I will open it up for anyone to work on it.

[rukaiya2000]

I would like to contribute to this.

[alodahl]

Hi @rukaiya2000, I will add you. Be sure to follow this contributing guide if this is your first Techtonica issue. https://github.com/Techtonica/curriculum/blob/master/CONTRIBUTING.md

[thisLinda]

I would like to work on this issue (or any easy/beginner labeled issue).

[Kundan28]

@rukaiya2000 Are you still working on this issue, please reply or someone else would be assigned to this issue.

[rukaiya2000]

Please assign this to someone else.

[Kundan28]

Please assign this to someone else.

Sure.

[Kundan28]

@thisLinda Do you want to work on this issue ?

[thisLinda]

Yes I do!

On Wed, Apr 29, 2020, 13:14 Kundan [e-mail] wrote:

@thisLinda https://github.com/thisLinda Do you want to work on this
issue ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Techtonica/curriculum/issues/1281#issuecomment-621346317,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIIG7MQ4WRQHK4AUBRBQDDDRPBN6PANCNFSM4LMCBSAA
.

[Kundan28]

Hi @thisLinda , I have added you. Be sure to follow this contributing guide if this is your first Techtonica issue. https://github.com/Techtonica/curriculum/blob/master/CONTRIBUTING.md

[thisLinda]

Completed 1281.

Researching this issue I found no links that lead to a 404 error. I checked the page that apparently had the error and all links are active. https://github.com/Techtonica/curriculum/blob/master/CONTRIBUTING.md#step-1-gssoc-participants

New issue.
There is an error on this page with the last hyperlink ('template docs in this folder'). When clicked it leads to the current page. https://github.com/Techtonica/curriculum/tree/master/_templates#instructions

[Kundan28]

Completed 1281.

Researching this issue I found no links that lead to a 404 error. I checked the page that apparently had the error and all links are active. https://github.com/Techtonica/curriculum/blob/master/CONTRIBUTING.md#step-1-gssoc-participants

New issue.
There is an error on this page with the last hyperlink ('template docs in this folder'). When clicked it leads to the current page. https://github.com/Techtonica/curriculum/tree/master/_templates#instructions

@vegetabill

[Deeksha2501]

Is this issue still open?
I would like to work on it.

[Kundan28]

Is this issue still open?
I would like to work on it.

@thisLinda is already assigned to this issue.

[thisLinda]

Kundan I emailed about the issue. There is no longer any issue with respect
to the 404--it seems to have been fixed--but I did find another. I didn't
do a pull request because there is no change to be made.

On Fri, May 8, 2020 at 12:29 AM Kundan [e-mail] wrote:

Is this issue still open?
I would like to work on it.

@thisLinda https://github.com/thisLinda is already assigned to this
issue.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Techtonica/curriculum/issues/1281#issuecomment-625623487,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIIG7MTWFBC2NOGQKFFJATTRQODBLANCNFSM4LMCBSAA
.

[Tawishi]

Kundan I emailed about the issue. There is no longer any issue with respect to the 404--it seems to have been fixed--but I did find another. I didn't do a pull request because there is no change to be made.
…

@Kundan28 this is because I fixed the issue already. https://github.com/Tawishi/curriculum/commit/fbe2566c32890516a08b2b3615d526ca148c2cf8

[Kundan28]

@Kundan28 this is because I fixed the issue already. Tawishi@fbe2566

But you were not assigned to this issue and you have to create a PR for that instead of directly making the changes in master.

[Tawishi]

@Tawishi since you are still working on #1189 I will leave this unassigned for 7 days so you can have the opportunity to work on it since you created it. After that I will open it up for anyone to work on it.

I did it cause of this comment and sorry, I forgot to create a PR.😔

[Kundan28]

@Tawishi since you are still working on #1189 I will leave this unassigned for 7 days so you can have the opportunity to work on it since you created it. After that I will open it up for anyone to work on it.

I did it cause of this comment and sorry, I forgot to create a PR.😔

I could understand but without PR you would not get the points for this.

[alodahl]

@Tawishi it looks like you committed to your own forked repo. You still need to make a PR for this repo.

[Tawishi]

@Tawishi it looks like you committed to your own forked repo. You still need to make a PR for this repo.

I am just figuring out how to squash the commits and remove the unnecessary ones.

[alodahl]

Alright. We'll be ready to review a PR when it is ready.

[thisLinda]

Following up on my messages of May 1 and May 8 (above), I did identify another issue which is defined in the first message.

I continue to be available to work on any easy/beginner issue if a gssoc20 participant is not able.

[alodahl]

@thisLinda can you elaborate on the existing issue? I thought you meant it didn't need to be fixed.

[thisLinda]

Issue #1281 had been fixed without a pull request as previously discussed.

I checked all the links on the page and discovered a different issue https://github.com/Techtonica/curriculum/tree/master/_templates. When you click on the very last link (a hyperlink: 'template docs in this folder') on the page it leads to the page it is already on rather than a different page.

Okay I am ready to get started
Use the template docs in this folder.

[alodahl]

Thanks @thisLinda , but that is actually the intended functionality of readmes - to be presented while you look at a parent folder. If you actually go to the Readme and click on that link, it should take you back to the _templates folder.

[alodahl]

Hi @Tawishi do you need any help?