Cura: Camera control bugs (Cura 2.3.1)

Created on 17 Dec 2016 · 8Comments · Source: Ultimaker/Cura

It looks right place to report Cura bugs
And sorry about my bad English.

I found 2 bugs with camera control and made fixes in "CameraTool.py" file

1. Zoom in bug.

When you continue zoom in after you don't see visual difference, then you must zoom out same amount after you will see visual zoom out.

Fix: In CameraTool.py "self._min_zoom = 0" but mathematically it will move endlessly closer to 0.
So min zoom should be example 1
"self._min_zoom = 1" is fixing that bug

2. space + mouse zoom jump

Space + mouse zoom "jump"(zoom in or out) sometimes when start new zoom. ( only with "space + mouse" zoom)

Fix: Script don't reset sometimes "self._start_y" value before next zoom.
added reset when "space" is not active.

    def initiateZoom(self, event):
        if event.type is event.MousePressEvent:
            return False

        #added 2 lines to fix that bug
        elif event.type is Event.MouseMoveEvent and self._space_is_active is False: #space -> mousemove
            self._start_y = None

        elif event.type is Event.MouseMoveEvent and self._space_is_active is True: #space -> mousemove

Uranium FixeSolved Bug

Source

Ando120

Most helpful comment

Here is instructions on making a pull request https://help.github.com/articles/creating-a-pull-request/

nickthetait on 19 Dec 2016

👍3

All 8 comments

It looks right place to report Cura bugs

It is! Thank you. I'll add this to our tracker so that it gets planned.

You seem to have already made some steps to try and fix the code. You could make those changes with a pull request, if you like. We'll then review them and test them and you'll get proper attribution, your username being forever lodged in our commit history. Otherwise we'll eventually make these changes ourselves.