Cudatext: Find dlg input change with 'Hi', results are not updated

[Alexey-T]

from @xcme

1. Highlighting sometimes doesn't work during changing text on search string
   Hi is "on", text is bb bb b b, Ctrl+F, type "zb", then remove "z". The "b" letter should be highlighted but usually it isn't

2. Highlighting doesn't work during changing source text (old issue)
   Hi is "on", text is b. Ctrl+F, type "b", Alt+E, Ctrl+F, "z" (replacing "b"), Ctrl+Z. Now "b" is here but is not highlighted

[Alexey-T]

@xcme I tried to repro it on Wine fresh installed/unzipped Cud on linux- no repro. any repro for fresh Cud?

[xcme]

@Alexey-T, yes, 1.133.6.4d, just unzipped. Tried again and it was reproduced.

Do you have windows to test? There are official (from Microsoft) images for hypervisors for testing purposes. If your machine has enough resources you can run in under Linux in VirtualBox and it could be used without any license/activation.

I can record a short demo tomorrow evening if you need, I think.

[Alexey-T]

I have a repro..
If I see it OK, then simple mouse-whell-scroll over editor repaints it, and it's ok then?

[Alexey-T]

updated the beta. seems solved.

[Alexey-T]

@xcme pls write if it's not solved.

[xcme]

@Alexey-T, the first one is solved, but the second one isn't

[Alexey-T]

@xcme what if you 'repaint' the editor (e.g. by resize the window, or do mouse-wheel-scroll)? then frames are visible?
-- for item 2.

[xcme]

No. Mouse or repaint doesn't work. I use 1.133.6.4f beta for testing.

[Alexey-T]

pls reproduce this on 1.134 release?

[xcme]

Same in 1.134. But I noticed if I change tab and then go back now it's OK. In short, issue appears if the text in main window appears after that is has been placed it search string. So, other way to reproduce the same:

1. Put "z" in the search string
2. Put "z" in main window. It's not highlighted
3. Change the tab and then go back. Now it's highlighted.

[Alexey-T]

hmm. So you suggest to update 'Hi' results on any text change? code doesn't do it. and it will be slower.

much slower text editing!
maybe its OK to update 'Hi' results as now?

[xcme]

May be an option to do it if search panel (find dialog) is visible? ST does that.
This option could be disabled by default. But users could enable if and get behavior like ST. For those who works with small files there will be no difference in regards the speed. I'd definitely enable it :)

[Alexey-T]

Adding this. 'find_hi_max_lines' option is here already. no need in new one.
will put the new beta to /c folder - 10min.

it will update 'Hi' result in on_change_slow--- last change + a pause.

[xcme]

"py_change_slow"?

Yes, fixed. Thanks.