Cudatext: plugin "Open URL" bugreport, mouse selection opens the URL

[Alexey-T]

quote--
Whenever I select some text (with mouse) which includes an url the plugin tries to open the url (not clicking, guess the event is "on mouse release" or something - if text starts with url - the open dialogue pops up, e.g., when I want to copy/paste a portion of text). In real life (for me) that happens all the time and is unwanted. Since configuration does not allow any other option than "clicking" the only option is to disable it. I guess it is a bug that selection of text (with mouse button hold down) also triggers the link.

Maybe an idea is to introduce a combination of ctrl+click or custom hotkeys, double click etc. like in other editors to avoid this unwanted behavior.

[Alexey-T]

my repro:
on text sdfsdf sd http://yahoo.com dd
select by mouse from "sd" until "yahoo", URL opens.
now i deleted OpenURL config file and cannot repro. someone can repro this?
@dinkumoil @kvichans @iRamSoft

[dinkumoil]

I can not reproduce this issue. Tested with _CudaText_ v1.98.2.0

My OpenURL plugin config file:

[op]
chrome=chrome
chrome_pvt=chrome --incognito
firefox=firefox.exe
firefox_pvt=firefox.exe -private-window
opera=opera
opera_pvt=opera -newprivatetab
tool_1=
tool_2=
handle_click=1
action_on_click=0

BTW:

• If I set action_on_click to 3 (in order to start _Firefox_ in a normal window), the plugin fails to start _Firefox_.
• Even if I provide the full path to _Firefox_ it fails (I guess because of the space characters in the Program Files part of its path).
• It also fails if I surround the path with double quotes. When I look into the config file again, I can see that the double quotes have been removed by the plugin.
• If I use %ProgramFiles% environment variable it fails as well, the error message states that path %ProgramFiles%\... has not been found (that means environment variable expansion does not work).

It seems like the only way to make the plugin starting another browser than the standard browser is to add the browser's path to the PATH variable.

[Alexey-T]

if I surround the path with double quotes. When I look into the config file again, I can see that the double quotes have been removed by the plugin

cannot see this on Linux, my config is

[op]
handle_click=1
action_on_click=-1
chrome="chrome"
chrome_pvt="chrome" --incognito
firefox="firefox"
firefox_pvt="firefox" -private-window
opera=opera
opera_pvt=opera -newprivatetab
tool_1=
tool_2=

now plugin writes it and quotes are kept.

[dinkumoil]

plugin writes it and quotes are kept

On Windows not.

To say it more clearly:

• Open config file of _OpenURL_ plugin.
• Set action_on_click to 3.
• Surround firefox or even the full path C:\Program Files\Mozilla Firefox\firefox.exe with double quotes and save the file.
• Terminate _CudaText_ and restart it.
• Open config file of _OpenURL_ plugin -> the quotes have been deleted.

[dinkumoil]

I have updated my last comment, now contains new important changes for repro steps.

[Alexey-T]

thanks for this report, will see on Win10.

[Alexey-T]

@dinkumoil applied the fix, link above. pls test - now quotes must be kept, I tested in console.

[dinkumoil]

Would you provide a compiled EXE of _CudaText_ beta, please? Compiling by myself involves starting up a VM and updating and reinstalling all required packages and Cud sources. That's time consuming and too much effort for doing it during work time.

[dinkumoil]

Tested beta from #2544, double quotes in config file are preserved now. Thank you!