Core: Consider upgrading PHPUnit version notice

Created on 14 Jun 2019  路  2Comments  路  Source: flarum/core

Feature Request

  • According to this issue, the @expectedException annotation will be deprecated in future PHPUnit versions.
  • According official PHPUnit site, the PHPUnit 6 version supports php-7.0, and it's not supported currently.
    Using PHPUnit 7 or PHPUnit 8 instead.

Suggested solution

  • Upgrading the PHPUnit version to 7 or 8 if possible.
    And it seems that this project still supports php-7.1, I think it's proper to use PHPUnit 7.
  • The @expectedException will be deprecated. Using the expectException method instead.

Once this issue is accepted, I would be happy to do this and create related PR :).

Most helpful comment

Yeah this makes a lot of sense. Especially because we already went to php 7.1. Feel free to send in a pr for this.

Thank you for pointing this out 馃憤

All 2 comments

Yeah this makes a lot of sense. Especially because we already went to php 7.1. Feel free to send in a pr for this.

Thank you for pointing this out 馃憤

I've taken care of the deprecated annotation. We're already running PHPUnit 7.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

franzliedke picture franzliedke  路  4Comments

datitisev picture datitisev  路  3Comments

Ralkage picture Ralkage  路  3Comments

tobyzerner picture tobyzerner  路  4Comments

MichaelBelgium picture MichaelBelgium  路  4Comments