Core: GitHub login, pop up is in the wrong size, no scroll bars

[PeopleInside]

This issue will be simple:

The GitHub plugin show a pop up that is cutted and has no scrolls bars.
Facebook and twitter pop up are correct, github not. Can be this correct?

[datitisev]

I can't reproduce with Chrome Version 72.0.3626.28 (Official Build) beta (64-bit)

However, I CAN reproduce with Firefox Developer Edition 64.0b13 and 65.0b5 (64-bit)

[PeopleInside]

True, i do not use Chrome much. On Chrome the issue is not present but is present on the stable version of Firefox. You also tested on developers version :D great.

[Ralkage]

I can also reproduce this on both FireFox Dev Edition and the standard edition as well (64bit).

IE11 as well, if not worse 😂 (Who uses IE anymore anyways? 😉 )

[PeopleInside]

Thanks, how can i apply and try this patch?

[franzliedke]

@PeopleInside You could use our demo, once it has updated (although that will require enabling and configuring Facebook login with an app ID and secret.

Other than that, wait for discuss to be updated or try a local install. :smile:

[PeopleInside]

Umh i changed the scroll bar from no to yes on my install but still see the issue when i press to login with Github https://community.peopleinside.it/ why? I cleared flarum cache.

[datitisev]

@PeopleInside You'd need to build the JS dist file as well so the JavaScript is recompiled.

[PeopleInside]

Done thanks. Works