Core: Tab name not updated if logo is clicked

[manurohr]

Bug Report

Current Behavior
If you go to any discussion, the tab of browser displays the name of post which is fine. If you click logo up left, the tab name remain the same without any udpate even you are on the tagspage. If the landing page was discussion list page, the tab is updated correctly. This small bugs only concerns if the tagspage was chosen as landing page.

Steps to Reproduce
Make sure, the start page is tagspage.

1. Go to any discussion
2. Click on logo
3. Check tab name.

Expected Behavior
If you are on any discussion and click logo, the tab name shall be updated correctly.

Environment

• Flarum 0.1.0-beta.7PHP 7.0.27-0+deb9u1

[franzliedke]

I can't reproduce this on discuss.flarum.org.

What I tried:

1. Visit https://discuss.flarum.org/ directly. Click on a discussion, navigate back to homepage via logo. Check URL.
2. Visit a discussion directly. Navigate to homepage via logo. Check URL.

Both worked.

@manurohr Can you reproduce the bug on discuss.flarum.org as well? If so, what are the exact steps?

[datitisev]

I can't reproduce this on my local beta 7.1 installation either.
Are there any errors in the console that possibly stop the code running before the title is set, @manurohr?

[franzliedke]

Also, what browser are you using?

[manurohr]

I have tried this before reporting on discuss.flarum.org and it worked because your start page is discussion page, not tags page. In my flarum instance the start page is tags page. I do not see any errors in the console nor did clearing cache worked.
In following browsers same behaviour:

• FF v60
• Chrome v67
• Safari v11

I have tested in local and production environment.

[manurohr]

Flarum core 0.1.0-beta.7 (c6aeeeb3c1d5cf92c586c9f8ee43d2127d0fb933)
PHP 7.1.12
Loaded extensions: Core, date, libxml, openssl, pcre, sqlite3, zlib, bcmath, bz2, calendar, ctype, curl, dom, hash, fileinfo, filter, ftp, gd, SPL, iconv, intl, json, ldap, mbstring, session, standard, mysqlnd, PDO, pdo_mysql, pdo_sqlite, apcu, posix, readline, Reflection, mysqli, SimpleXML, soap, sockets, exif, tokenizer, wddx, xml, xmlreader, xmlrpc, xmlwriter, xsl, zip, apc, Phar, imap, mcrypt, gettext, pgsql, pdo_pgsql
EXT flagrow-analytics 0.6.0
EXT flarum-approval v0.1.0-beta.7
EXT flarum-bbcode v0.1.0-beta.5
EXT wiwatsrt-best-answer v0.1.0-beta.11
EXT datitisev-dashboard v0.1.0-beta.6.1
EXT cbmainz-de 0.7.1
EXT flarum-emoji v0.1.0-beta.6
EXT flarum-english v0.1.0-beta.7
EXT flagrow-bazaar 0.2.4
EXT flagrow-byobu 0.1.2
EXT flagrow-impersonate 0.1.0
EXT flagrow-split 0.2
EXT flagrow-terms 0.2.3 (502f94d07c380835544aadbd0341aa381386ea5a)
EXT flagrow-upload 0.6.0
EXT flagrow-user-directory dev-develop (ba7961687c2dba73ebe0be02087789e956e231da)
EXT flagrow-users-list 0.1.2
EXT flarum-flags v0.1.0-beta.7
EXT sijad-google-analytics 0.1.1
EXT sijad-recaptcha 0.0.2
EXT flarum-likes v0.1.0-beta.6
EXT sijad-links 0.1.0-beta.6
EXT flarum-lock v0.1.0-beta.7
EXT flarum-markdown v0.1.0-beta.5
EXT s9e-mediaembed 0.3.2
EXT flarum-mentions v0.1.0-beta.7
EXT sijad-pages 0.1.0-beta.3
EXT reflar-polls 0.1.1
EXT flarum-sticky v0.1.0-beta.7
EXT flarum-subscriptions v0.1.0-beta.6
EXT flarum-suspend v0.1.0-beta.7
EXT flarum-tags v0.1.0-beta.7 (5f126049eead78d4a25eec0edfbe5f969465b253)
Base URL: http://localhost:7888/myflarum
Installation path: /Applications/MAMP/htdocs/myflarum

[ardacebi]

I accidentally re-posted this #1483 issue without seeing this.

I posted a video there showing the issue @manurohr. Watch that.

@franzliedke You should try multiple times to see the error.

[ardacebi]

Confirming issue.

[franzliedke]

Hmm, watching that video makes me think there might be a timing issue, as you were often clicking before the page was fully loaded.

[ardacebi]

@franzliedke Yes, this issue is the same probably.

You can't reproduce the bug with only one click.

[ardacebi]

Someone can immediately switch a topic after clicking on one accurately and have this bug.

[franzliedke]

Closing this one in favor of #1483, which is a little cleaner and also mentions the back button. :)