Core: [Emoji] Duplicate emojis on dropdown list

Created on 25 May 2016  路  4Comments  路  Source: flarum/core

Whenever I type :tong, the first 3 results are exactly the same.
I don't know if this is also a bug for other entries, I just know about the tongue emoji (:tongue:)

Screenshot:
captura de pantalla 2016-05-25 a las 5 04 15 pm

typbug

Most helpful comment

Darn, I wanted to fix this before any of you noticed. ;)

It's a small regresssion, part of my recent fix. Because we first search for exact matches from the beginning, and only switch to fuzzy matches if we haven't found enough (7) exact matches, it can sometimes happen that a fuzzy match duplicates an exact match.

Although, to be honest, that does not explain how "tongue" can appear three times.

All 4 comments

Confirmed ... while responding to Franz's long emoji thread I got more _oden_ than I bargained for.

screenshot

It looks as though it might be offering recently selected items as suggestions ...

Darn, I wanted to fix this before any of you noticed. ;)

It's a small regresssion, part of my recent fix. Because we first search for exact matches from the beginning, and only switch to fuzzy matches if we haven't found enough (7) exact matches, it can sometimes happen that a fuzzy match duplicates an exact match.

Although, to be honest, that does not explain how "tongue" can appear three times.

@franzliedke I don't know how the dropdown works but if you deduplicate entries I recommend you do it by codepoint (e.g. 26f5) rather than shortname. For instance, both :book: and :open_book: point to the same emoji: U+26F5. Typing this I found that's what GitHub does too, if you type :open_ it will suggest :book: but not :open_book:.

Cheers, fixed.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Ralkage picture Ralkage  路  40Comments

tobyzerner picture tobyzerner  路  55Comments

MichaelBelgium picture MichaelBelgium  路  31Comments

dcsjapan picture dcsjapan  路  43Comments

tobyzerner picture tobyzerner  路  76Comments