Summary of the complete Changelog: https://github.com/owncloud/core/blob/stable10/CHANGELOG.md
This summary has a QA purpose.
[x] Fix for error when querying non present log_secret - #30470 @patrickjahns
Free resources in preview providers - #30533
[x] Removed private oc_current_user Javascript variable - #30486 #30556
@PVince81 - evaluate "oc_current_user" in 10.0.5 and 10.0.8 RC1
[x] Remove app store config values from config.sample.php - #30422 @patrickjahns
To test checksum repair command, upload a file and then manually modify checksum column in oc_filecache to something else.
More notes here: https://github.com/owncloud/documentation/issues/4014
user_ldap appRemoved private oc_current_user Javascript variable - #30486 #30556
We had a regression in calendar which was resolved already https://github.com/owncloud/calendar/pull/884
@DeepDiver1975 @PVince81
Can we put this in "developer" release notes - so third party developers will know about this change ?
@patrickjahns Tested:
Fix validation for new encryption storage key location - #30357
Works perfectly. Please go ahead and tick the checkbox
Added repair step to fix orphaned reshares
Currently untested with oracle... any chance to test it with it? I haven't found easy support to test it with oracle.
I'm marking as passed as it works fine for mysql and postgresql, although the performance looks scary for large datasets on first sight. I'm not sure how fast it will behave or if we can do something about it.
@jvillafanez
docker run -p 1521:1521 deepdiver/docker-oracle-xe-11g - then you have oracle.
If you need a container with oracle php modules - you can use https://hub.docker.com/r/owncloudci/php/tags
Note:
with the oracle container above - database username is autotest - database password is owncloud and database is XE - ref: https://github.com/owncloud/core/blob/master/tests/drone/install-server.sh
Can we put this in "developer" release notes - so third party developers will know about this change ?
This was never supposed to be public API but people still used this.
We can add a note in the regular release notes as we don't have developer release notes.
Tested "Fixed regression where a user could not set own email address in the settings page - #30319"
Tested "Set empty authtoken names to 'none' as empty is not allowed any more - #30908"
Ticked "Added config.php option to select apps to ignore missing signature file (mostly for themes)" as Confirmed by @thommierother https://github.com/owncloud/core/pull/30891#issuecomment-381077539
Tested "Guide users to also check spelling for typos in federated share id - #30355" => with failure: no_entry missing code path #30159 (comment) (would consider "known issue" as it's minor)
Tested "Added user:modify command to core - #30652" => works changing display name and email
Tested "Fix failure of shares which are already moved with transfer ownership - #30161", not working 100% as expected, raised bug https://github.com/owncloud/core/issues/31150
Added:
Configurable minimum characters before autocomplete user searches https://github.com/owncloud/core/pull/30798
Found bug "Public link share name length check is inaccurate": https://github.com/owncloud/core/issues/31157
Tested: Better label for CORS in settings section - #30663 -> OK!
Tested: Allow regular users to change their CORS domains - #30649 -> OK!
Tested by setting custom Origin header in curl for ocs requests. If origin matched the whitelisted origin, correct CORS headers are present. CORS-Whitelists are isolated between different users.
Tested: Adding a system configuration for global CORS domains - #30906 -> OK!
Tested: Fix CORS OPTIONS request for unauthenticated requests - #30912 -> OK!
OPTIONS with "Access-Control-Request-Method" header returns 200 on un-authenticated ocs-api request.
Failed Test "Make theming work when theme app is outside the ownCloud root - #30477" and failed, raised https://github.com/owncloud/core/issues/31170
Added "regression test retention / trashbin expiration" checkbox as the fix of the matching item moves more code around and does more than just fixing the issue.
Tested: Keep null in getMetaData in Checksum storage wrapper, fixes some files:scan scenarios #30302 -> OK!
Filescan does not crash on unreadable local and ext-storage files.
Tested: Fixing logout for app password scenario - #30591 -> OK!
No login failed messages in log when logging in with app password.
@voroyam Can you please test app-password login in combination with ldap? No "Login-Failed" Messages should appear in the log.
Added "test app-pasword login with ldap"
Missing items and items to add since RC1:
[x] Trigger event when logging - #31121 @PVince81 - tested with custom app
[x] Added Symfony events for configuration changes (config.php and appconfig) - #30788 #30937 #31107 @SergioBertolinSG
Tested: Fix some CSRF issues on Webdav endpoint by only checking for POST method - #30358 -> OK!
PROPFIND via Postman works without CSRF-Token
Testing "Do not log errors when uploading forbidden file format"
❌
Tested with files_antivirus master:

Behavior with old antivirus-app:
10.0.8RC3 + files_antivirus from marketplace

10.0.7 + files_antivirus from marketplace

Tested "Make syslog output configurable, introduce new default that includes the request id ", works
Testing: Added config switch to enable fallback to http scheme when creating fed shares
Receiving side just sees this error message when going via http

Failed: Files app UI now retries chunk uploads in web UI on stalled uploads, will be reverted: https://github.com/owncloud/core/pull/31185
Retested "Make theming work when theme app is outside the ownCloud root - #30477", works in RC3
From https://github.com/owncloud/notifications/pull/180
Tested "Properly trigger file-related Symfony events when chunking" with old chunking, new chunking and no chunking: events are triggered
Tested "Use storage specific move operation for object store - #30817" => OK!
Retested Fix App Framework ApiContoller initialization to fix thumbnail access - #31104 - @SergioBertolinSG #29914 (comment) Not working in RC2, Works in RC3.
Tested "regression test retention / trashbin expiration" - works fine (at least no regression). Need however to clarify what is the expected behavior about the min retention period. Will open a separate issue for that.
Failed: "Added config switch to enable fallback to http scheme when creating fed shares - #30646", tested by @DeepDiver1975. It seems the code is not triggered / the fix is in the wrong location.
@DeepDiver1975 will fix it. Ticket: https://github.com/owncloud/core/issues/31194
Tested: Catch session unavailable exception - #30347 #30623 -> OK!
Additional codereview because hard to reproduce, automated tests should be enough
❗️ Confusing behaviour with single user syncing if the user doesn't exists (Ticket opened in https://github.com/owncloud/core/issues/31207 for 10.0.9)
root@3b450a98bad4:/opt/owncloud# sudo -u www-data ./occ user:sync -u miimi "OC\User\Database"
If unknown users are found, what do you want to do with their accounts? (removing the account will also remove its data)
[0] disable
[1] remove
[2] ask later
> 2
Syncing miimi ...
These accounts that are no longer available in the backend:
miimi, , (no longer exists in the backend)
What do you want to do with their accounts? (removing the account will also remove its data)
[0] disable
[1] remove
> 0
Disabling accounts
miimi, , (no longer exists in the backend)
From a behavioural point of view, this doesn't look good. Asking first what to do was thought in order to sync a large number of users so you can set the appropiate action before start the syncing. With just one user this seems a bit pointless.
What really bothers me is that we should know at some point that the account doesn't exists. Asking what to do with a missing account is pointless, and then disabling or removing a missing account is misleading.
I'm not sure if there is an easy enough fix for this to include it in 10.0.8. Otherwise we'll likely have to delay the solution for 10.0.9.
-> tested "Prevent background scan to scan homes of users who never logged in"
tested during other test -> message not appearing
Tested "Federation fallback to http config switch" -> works as expected
RC testing is done, thanks a lot everybody for the big effort!
final smoke test here: https://github.com/owncloud/core/issues/31096#issuecomment-382798088
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.