Core: automatically accept incoming federated shares generate a notification, accepting the share from there renames it

Created on 18 Apr 2019  路  3Comments  路  Source: owncloud/core

Steps to reproduce

  1. set up 2 servers
  2. on server1 add server2 as trusted server
  3. on server1 enable Automatically accept remote shares from trusted servers
  4. share folder from server2 to server1

Expected behaviour

share is accepted, no notification, or notification that informs about new share but does not have any buttons to accept it

Actual behaviour

share is accepted, notification is shown allowing to accept the share again
doing so renames it to folder (2)

Server configuration

Operating system:
Ubuntu 18.04
Web server:
Apache2
Database:
MySQL
PHP version:
7.2
ownCloud version: (see ownCloud admin page)
10.2.0.1
Updated from an older ownCloud or fresh install:
fresh
Where did you install ownCloud from:
RC1 tarball

The content of config/config.php:

{
    "system": {
        "instanceid": "oc1fqx9gxt25",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "172.17.0.1"
        ],
        "datadirectory": "\/home\/artur\/www\/owncloud-10.2.0\/rc1_a\/data",
        "overwrite.cli.url": "https:\/\/172.17.0.1\/owncloud-10.2.0\/rc1_a",
        "dbtype": "mysql",
        "version": "10.2.0.1",
        "logtimezone": "UTC",
        "apps_paths": [
            {
                "path": "\/home\/artur\/www\/owncloud-10.2.0\/rc1_a\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/home\/artur\/www\/owncloud-10.2.0\/rc1_a\/apps-external",
                "url": "\/apps-external",
                "writable": true
            }
        ],
        "memcache.local": "\\OC\\Memcache\\APCu",
        "ldapIgnoreNamingRules": false,
        "dbname": "owncloud-10-2-0-rc1-a",
        "dbhost": "localhost",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "skeletondirectory": "\/home\/artur\/www\/owncloud-core\/apps\/testing\/data\/webUISkeleton",
        "groups.enable_medial_search": true
    }
}

List of activated apps:

Enabled:
  - comments: 0.3.0
  - configreport: 0.2.0
  - dav: 0.4.0
  - encryption: 1.3.1
  - federatedfilesharing: 0.4.0
  - federation: 0.1.0
  - files: 1.5.2
  - files_external: 0.7.1
  - files_sharing: 0.11.0
  - files_trashbin: 0.9.1
  - files_versions: 1.3.0
  - files_videoplayer: 0.10.1
  - firstrunwizard: 1.2.0
  - market: 0.4.0
  - notifications: 0.5.0
  - oauth2: 0.4.0
  - provisioning_api: 0.5.0
  - systemtags: 0.3.0
  - updatenotification: 0.2.1
  - user_ldap: 0.13.0
Disabled:
  - external
  - user_external

Are you using external storage, if yes which one: local/smb/sftp/...
yes
Are you using encryption: yes/no
yes
Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
LDAP

LDAP configuration (delete this part if not used)


+-------------------------------+------------------------------------------------------------------------------------------------------------+
| Configuration                 | LDAPTestId                                                                                                 |
+-------------------------------+------------------------------------------------------------------------------------------------------------+
| hasMemberOfFilterSupport      |                                                                                                            |
| hasPagedResultSupport         |                                                                                                            |
| homeFolderNamingRule          |                                                                                                            |
| lastJpegPhotoLookup           | 0                                                                                                          |
| ldapAgentName                 | cn=admin,dc=owncloud,dc=com                                                                                |
| ldapAgentPassword             | ***                                                                                                        |
| ldapAttributesForGroupSearch  |                                                                                                            |
| ldapAttributesForUserSearch   |                                                                                                            |
| ldapBackupHost                |                                                                                                            |
| ldapBackupPort                |                                                                                                            |
| ldapBase                      | dc=owncloud,dc=com                                                                                         |
| ldapBaseGroups                | dc=owncloud,dc=com                                                                                         |
| ldapBaseUsers                 | dc=owncloud,dc=com                                                                                         |
| ldapCacheTTL                  | 600                                                                                                        |
| ldapConfigurationActive       | 1                                                                                                          |
| ldapDynamicGroupMemberURL     |                                                                                                            |
| ldapEmailAttribute            | mail                                                                                                       |
| ldapExperiencedAdmin          | 0                                                                                                          |
| ldapExpertUUIDGroupAttr       |                                                                                                            |
| ldapExpertUUIDUserAttr        | uid                                                                                                        |
| ldapExpertUsernameAttr        |                                                                                                            |
| ldapGroupDisplayName          | cn                                                                                                         |
| ldapGroupFilter               | (&(|(objectclass=posixGroup)))                                                                             |
| ldapGroupFilterGroups         |                                                                                                            |
| ldapGroupFilterMode           | 0                                                                                                          |
| ldapGroupFilterObjectclass    | posixGroup                                                                                                 |
| ldapGroupMemberAssocAttr      | memberUid                                                                                                  |
| ldapHost                      | localhost                                                                                                  |
| ldapIgnoreNamingRules         |                                                                                                            |
| ldapLoginFilter               | (&(|(objectclass=inetOrgPerson))(|(uid=%uid)(|(mailPrimaryAddress=%uid)(mail=%uid))(|(displayName=%uid)))) |
| ldapLoginFilterAttributes     | displayName                                                                                                |
| ldapLoginFilterEmail          | 1                                                                                                          |
| ldapLoginFilterMode           | 0                                                                                                          |
| ldapLoginFilterUsername       | 1                                                                                                          |
| ldapNestedGroups              | 0                                                                                                          |
| ldapOverrideMainServer        |                                                                                                            |
| ldapPagingSize                | 500                                                                                                        |
| ldapPort                      | 389                                                                                                        |
| ldapQuotaAttribute            |                                                                                                            |
| ldapQuotaDefault              |                                                                                                            |
| ldapTLS                       | 0                                                                                                          |
| ldapUserDisplayName           | displayName                                                                                                |
| ldapUserDisplayName2          |                                                                                                            |
| ldapUserFilter                | (|(objectclass=inetOrgPerson))                                                                             |
| ldapUserFilterGroups          |                                                                                                            |
| ldapUserFilterMode            | 0                                                                                                          |
| ldapUserFilterObjectclass     | inetOrgPerson                                                                                              |
| ldapUserName                  | samaccountname                                                                                             |
| ldapUuidGroupAttribute        | auto                                                                                                       |
| ldapUuidUserAttribute         | auto                                                                                                       |
| turnOffCertCheck              | 0                                                                                                          |
| useMemberOfToDetectMembership | 1                                                                                                          |
+-------------------------------+------------------------------------------------------------------------------------------------------------+

Client configuration

Browser:
FF
Operating system:
Ubuntu 18.04

Bug

All 3 comments

@karakayasemi can you have a look ? maybe we need to prevent the notification to be sent in the first place ?

@individual-it I could not reproduce the issue. Even when I share with a folder that receiver has a folder with the same name, no notification was shown and it is correctly renamed as folder(2).
I believe I installed a similar instance to you by enabling user_ldap and encryption. My instance enabled app list:
````
Enabled:

  • comments: 0.3.0
  • dav: 0.4.0
  • encryption: 1.3.1
  • federatedfilesharing: 0.4.0
  • federation: 0.1.0
  • files: 1.5.2
  • files_external: 0.7.1
  • files_sharing: 0.11.0
  • files_trashbin: 0.9.1
  • files_versions: 1.3.0
  • provisioning_api: 0.5.0
  • systemtags: 0.3.0
  • updatenotification: 0.2.1
  • user_ldap: 0.13.0
    config list:
    {
    "system": {
    "instanceid": "oc3m23ybew5p",
    "passwordsalt": "REMOVED SENSITIVE VALUE",
    "secret": "REMOVED SENSITIVE VALUE",
    "trusted_domains": [
    "owncloudmaster.com"
    ],
    "datadirectory": "\/var\/www\/html\/core2\/data",
    "overwrite.cli.url": "http:\/\/owncloudmaster.com",
    "dbtype": "sqlite3",
    "version": "10.2.0.1",
    "logtimezone": "UTC",
    "apps_paths": [
    {
    "path": "\/var\/www\/html\/core2\/apps",
    "url": "\/apps",
    "writable": false
    },
    {
    "path": "\/var\/www\/html\/core2\/apps-external",
    "url": "\/apps-external",
    "writable": true
    }
    ],
    "installed": true,
    "ldapIgnoreNamingRules": false
    },
    "apps": {
    "backgroundjob": {
    "lastjob": "2"
    },
    "comments": {
    "installed_version": "0.3.0",
    "types": "logging,dav",
    "enabled": "yes"
    },
    "core": {
    "installedat": "1556483882.2541",
    "lastupdatedat": "1556483882.2608",
    "public_webdav": "dav\/appinfo\/v1\/publicwebdav.php",
    "public_files": "files_sharing\/public.php",
    "first_install_version": "10.2.0.1",
    "lastcron": "1556485530",
    "default_encryption_module": "OC_DEFAULT_MODULE",
    "encryption_enabled": "yes"
    },
    "dav": {
    "installed_version": "0.4.0",
    "types": "filesystem",
    "enabled": "yes"
    },
    "encryption": {
    "recoveryKeyId": "recoveryKey_1ce4b77d",
    "publicShareKeyId": "pubShare_1ce4b77d",
    "masterKeyId": "master_1ce4b77d",
    "installed_version": "1.3.1",
    "types": "filesystem",
    "enabled": "yes",
    "useMasterKey": "1"
    },
    "federatedfilesharing": {
    "installed_version": "0.4.0",
    "types": "filesystem",
    "enabled": "yes",
    "auto_accept_trusted": "yes"
    },
    "federation": {
    "installed_version": "0.1.0",
    "types": "authentication",
    "enabled": "yes"
    },
    "files": {
    "installed_version": "1.5.2",
    "types": "filesystem",
    "enabled": "yes",
    "cronjob_scan_files": "500"
    },
    "files_external": {
    "installed_version": "0.7.1",
    "types": "filesystem",
    "enabled": "yes"
    },
    "files_sharing": {
    "installed_version": "0.11.0",
    "types": "filesystem",
    "enabled": "yes"
    },
    "files_trashbin": {
    "installed_version": "0.9.1",
    "types": "filesystem",
    "enabled": "yes"
    },
    "files_versions": {
    "installed_version": "1.3.0",
    "types": "filesystem",
    "enabled": "yes"
    },
    "provisioning_api": {
    "installed_version": "0.5.0",
    "types": "prevent_group_restriction",
    "enabled": "yes"
    },
    "systemtags": {
    "installed_version": "0.3.0",
    "types": "logging",
    "enabled": "yes"
    },
    "updatenotification": {
    "installed_version": "0.2.1",
    "types": "",
    "enabled": "yes"
    },
    "user_ldap": {
    "installed_version": "0.13.0",
    "types": "authentication",
    "enabled": "yes",
    "ldap_host": "localhost",
    "ldap_port": "389",
    "ldap_backup_host": "",
    "ldap_backup_port": "",
    "ldap_base": "dc=owncloud,dc=com",
    "ldap_base_users": "dc=owncloud,dc=com",
    "ldap_base_groups": "dc=owncloud,dc=com",
    "ldap_dn": "cn=admin,dc=owncloud,dc=com",
    "ldap_agent_password": "**",
    "ldap_tls": "0",
    "ldap_turn_off_cert_check": "0",
    "ldap_user_name": "samaccountname",
    "ldap_display_name": "displayname",
    "ldap_user_display_name_2": "",
    "ldap_userfilter_objectclass": "inetOrgPerson",
    "ldap_userfilter_groups": "",
    "ldap_userlist_filter": "(|(objectclass=inetOrgPerson))",
    "ldap_user_filter_mode": "0",
    "ldap_group_filter": "",
    "ldap_group_filter_mode": "0",
    "ldap_groupfilter_objectclass": "",
    "ldap_groupfilter_groups": "",
    "ldap_group_display_name": "cn",
    "ldap_group_member_assoc_attribute": "uniqueMember",
    "ldap_login_filter": "(&(|(objectclass=inetOrgPerson))(uid=%uid))",
    "ldap_login_filter_mode": "0",
    "ldap_loginfilter_email": "0",
    "ldap_loginfilter_username": "1",
    "ldap_loginfilter_attributes": "",
    "ldap_quota_attr": "",
    "ldap_quota_def": "",
    "ldap_email_attr": "",
    "ldap_cache_ttl": "600",
    "ldap_override_main_server": "",
    "ldap_configuration_active": "1",
    "ldap_attributes_for_user_search": "",
    "ldap_attributes_for_group_search": "",
    "ldap_experienced_admin": "0",
    "home_folder_naming_rule": "",
    "has_memberof_filter_support": "0",
    "use_memberof_to_detect_membership": "1",
    "ldap_expert_username_attr": "",
    "ldap_expert_uuid_user_attr": "uid",
    "ldap_expert_uuid_group_attr": "memberUid",
    "last_jpegPhoto_lookup": "0",
    "ldap_nested_groups": "0",
    "ldap_paging_size": "500",
    "ldap_dynamic_group_member_url": ""
    }
    }
    }
    ````

I've made a very simple installation (no encryption, no LDAP) and it happens for me

```
{
"system": {
"instanceid": "oclyvjwln0vl",
"passwordsalt": "REMOVED SENSITIVE VALUE",
"secret": "REMOVED SENSITIVE VALUE",
"trusted_domains": [
"localhost"
],
"datadirectory": "\/home\/artur\/www\/owncloud-10.2.0\/rc1_c\/data",
"overwrite.cli.url": "http:\/\/localhost\/owncloud-10.2.0\/rc1_c",
"dbtype": "sqlite3",
"version": "10.2.0.1",
"logtimezone": "UTC",
"apps_paths": [
{
"path": "\/home\/artur\/www\/owncloud-10.2.0\/rc1_c\/apps",
"url": "\/apps",
"writable": false
},
{
"path": "\/home\/artur\/www\/owncloud-10.2.0\/rc1_c\/apps-external",
"url": "\/apps-external",
"writable": true
}
],
"installed": true,
"sharing.federation.allowHttpFallback": true
},
"apps": {
"backgroundjob": {
"lastjob": "7"
},
"comments": {
"installed_version": "0.3.0",
"types": "logging,dav",
"enabled": "yes"
},
"configreport": {
"installed_version": "0.2.0",
"types": "filesystem",
"enabled": "yes"
},
"core": {
"installedat": "1556516253.0148",
"lastupdatedat": "1556518058",
"public_webdav": "dav\/appinfo\/v1\/publicwebdav.php",
"public_files": "files_sharing\/public.php",
"first_install_version": "10.2.0.1",
"oc.integritycheck.checker": "[]",
"lastcron": "1556516499",
"lastupdateResult": "[]"
},
"dav": {
"installed_version": "0.4.0",
"types": "filesystem",
"enabled": "yes"
},
"federatedfilesharing": {
"installed_version": "0.4.0",
"types": "filesystem",
"enabled": "yes",
"auto_accept_trusted": "yes"
},
"federation": {
"installed_version": "0.1.0",
"types": "authentication",
"enabled": "yes"
},
"files": {
"installed_version": "1.5.2",
"types": "filesystem",
"enabled": "yes",
"cronjob_scan_files": "500"
},
"files_external": {
"installed_version": "0.7.1",
"types": "filesystem",
"enabled": "yes"
},
"files_sharing": {
"installed_version": "0.11.0",
"types": "filesystem",
"enabled": "yes"
},
"files_trashbin": {
"installed_version": "0.9.1",
"types": "filesystem",
"enabled": "yes"
},
"files_versions": {
"installed_version": "1.3.0",
"types": "filesystem",
"enabled": "yes"
},
"files_videoplayer": {
"installed_version": "0.10.1",
"types": "",
"enabled": "yes"
},
"firstrunwizard": {
"installed_version": "1.2.0",
"types": "",
"enabled": "yes"
},
"market": {
"installed_version": "0.4.0",
"types": "",
"enabled": "yes"
},
"notifications": {
"installed_version": "0.5.0",
"types": "logging",
"enabled": "yes"
},
"provisioning_api": {
"installed_version": "0.5.0",
"types": "prevent_group_restriction",
"enabled": "yes"
},
"systemtags": {
"installed_version": "0.3.0",
"types": "logging",
"enabled": "yes"
},
"updatenotification": {
"installed_version": "0.2.1",
"types": "",
"enabled": "yes"
}
}
}

Was this page helpful?
0 / 5 - 0 ratings