Core: Doubled folders when receiving shares through two groups

[jonasheinisch]

Steps to reproduce

1. Create two usergroups G1 and G2
2. Share a folder F with both groups
3. Create a user U belonging to both groups G1 and G2
4. Log in with U
   

   Expected behaviour

User U will have folder F in his files.

Actual behaviour

User U has folder F two times in his files (one is named "F (2)").

Server configuration

Operating system: Debian 8.0

Web server: Apache 2.0

Database: MySQL

PHP version: 5.6.20

ownCloud version: 9.0.2

Updated from an older ownCloud or fresh install: fresh install

Where did you install ownCloud from: via official aptitude repo

Signing status (ownCloud 9.0 and above): No errors have been found.

List of activated apps:

  - activity: 2.2.1
  - activitydefaults: 0.1.0
  - comments: 0.2
  - dav: 0.1.6
  - direct_menu: 0.7.1
  - external: 1.2
  - federatedfilesharing: 0.1.0
  - federation: 0.0.4
  - files: 1.4.4
  - files_pdfviewer: 0.8.1
  - files_sharing: 0.9.1
  - files_texteditor: 2.1
  - files_trashbin: 0.8.0
  - files_versions: 1.2.0
  - files_videoplayer: 0.9.8
  - firstrunwizard: 1.1
  - gallery: 14.5.0
  - notifications: 0.2.3
  - ownbackup: 0.3.8
  - provisioning_api: 0.4.1
  - systemtags: 0.2
  - templateeditor: 0.1
  - updatenotification: 0.1.0

The content of config/config.php:

<?php
$CONFIG = array (
  'updatechecker' => false,
  'instanceid' => 'qwerty',
  'passwordsalt' => '0815',
  'secret' => 'thisissecret',
  'trusted_domains' =>
  array (
    0 => 'www.xxx.de',
    1 => 'xxx.de',
  ),
  'datadirectory' => '/var/www/vhosts/xxx.de/httpdocs/data',
  'overwrite.cli.url' => 'https://www.xxx.de',
  'dbtype' => 'mysql',
  'version' => '9.0.2.2',
  'dbname' => 'owncloud',
  'dbhost' => 'localhost',
  'dbtableprefix' => 'oc_',
  'dbuser' => 'owncloud',
  'dbpassword' => 'dbpass',
  'logtimezone' => 'UTC',
  'installed' => true,
  'memcache.local' => '\\OC\\Memcache\\APCu',
  'mail_from_address' => 'info',
  'mail_smtpmode' => 'php',
  'mail_domain' => 'xxx.de',
  'theme' => 'mytheme',
);

Are you using external storage, if yes which one: no

Are you using encryption: no

Are you using an external user-backend, if yes which one: no

[PVince81]

Are you using different permissions ? If the permissions are the same, there is an algo that will merge the two folders.

[PVince81]

@rullzer

[jonasheinisch]

@PVince81 Yes, the permissions are identical.

[PVince81]

Hmm, then it could be a regression

[rullzer]

I most likely broke it then.
Thinking now why and if I had a reason.

[PVince81]

@rullzer any update ?

[PVince81]

I most likely broke it then.

@rullzer can you fix it then ?

[rullzer]

PR incomming... but I actually don't know why this grouping isn't happening properly on 9.0 since I did not touch the mountpoint stuff then...

[PVince81]

The PR in question is here https://github.com/owncloud/core/pull/25113

[vssware]

The problem happened when I upgrade from 9.0.2 to 9.0.3,It does not exist in my 9.0.2.

[jochenwezel]

what can / should I do in the meantime safely until the patch is availble with build 9.0.4?

1. delete these duplicated folders and just keep the very first, correct one in my list?
2. keep everything untouched

PLEA: In both cases, the provided update should correct all wrong data (so that the many users of our instance don't have to waste additional time to get a cleanup of their directory/share structure)

[PVince81]

@jochenwezel I just tested the PR and you're right that this needs a repair step, the duplicate folders aren't automatically deleted :disappointed:

This is likely because it creates an additional entry in the "oc_share" table as if the user had removed it.

Had a local test with the doubled folder, if I "unshare from self" one of the duplicate folders it will exclude it from view and the non-duplicate one remains. It looks fine as a workaround but so far I can't tell whether this will have side effects.

One visible side effect so far is that when opening the share panel for the remaining entry, it will only show that it was shared through one group instead of multiple.

[PVince81]

@felixboehm @cdamken @pako81 FYI

[PVince81]

Let's keep it open until the backports are merged:

• [x] stable9.1: https://github.com/owncloud/core/issues/25534
• [ ] stable9: https://github.com/owncloud/core/pull/25543

[PVince81]

• [x] check whether the fix also fixes https://github.com/owncloud/core/issues/25555

[PVince81]

• [ ] add more integration tests about renaming/moving received grouped shared folders

[PVince81]

• [x] TODO: fix repair routine to also cover https://github.com/owncloud/core/issues/25555 properly

[PVince81]

Just to clarify, now using this ticket to track any kind of "folder shared through multiple ways to the same user" resulting in the "recipient sees the folders multiple times" issue.

[PVince81]

• [ ] another case that needs to be covered: https://github.com/owncloud/core/pull/25568

[SMITR1]

Hi I ran into another issue, I applied the temporary fix for the sharing issue but now my owncloud doesn't want to sync with my mobile devices(Webdav or mobile app). Gives a HTTP error... can you please advise?

[PVince81]

@SMITR1 which ownCloud version do you have and which exact fix did you apply ? Depending on your ownCloud version, the fix is different. It is likely that you applied an incomplete fix.

[PVince81]

The PR is ready for testing: https://github.com/owncloud/core/pull/25543

Please help testing if you have a test system. (don't do it on a productive system as it increases the version)
The PR can be downloaded as patch: https://github.com/owncloud/core/pull/25543.patch

To test:

• the repair routine must properly repair the duplicate shares using a "best guess" approach in case users decided to keep the duplicates
• all newly created shares targetting the same user must be properly deduplicated.

[PVince81]

Regarding the workaround while waiting for 9.0.5: you can safely delete the duplicates. The repair routine will still be able to figure out what to do.

[PVince81]

Fix will be in 9.0.5 and 9.1.1.

[vssware]

Great, Tks a lot!

On Aug 16, 2016, at 7:50 PM, Vincent Petry <[email protected] [e-mail]> wrote:

Closed #24575 https://github.com/owncloud/core/issues/24575.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/owncloud/core/issues/24575#event-756925918, or mute the thread https://github.com/notifications/unsubscribe-auth/ACK4Gb9Xb8wOTiAjFJ9FheKDSY_kVvpGks5qgaPugaJpZM4IcEun.

[PVince81]

You can help testing with the 9.0.5 RC1: http://download.owncloud.org/community/testing/owncloud-9.0.5RC1.tar.bz2

[tavinus]

Sorry to reopen this, but I am still facing this problem on OC 9.1.2 (stable). Any ideas?

[PVince81]

@tavinus please make a new ticket and post reproduction steps and details about the sharing scenario. Use the issue template for that: https://raw.githubusercontent.com/owncloud/core/master/.github/issue_template.md

[functionportal]

I can still reproduce this problem in 9.1.4.2. This issue needs to be reopened.

[PVince81]

@craftyInstigator please make a new ticket and post reproduction steps and details about the sharing scenario. Use the issue template for that: https://raw.githubusercontent.com/owncloud/core/master/.github/issue_template.md.

Most important is to know what exact sharing scenario you are using and the order in which the shares were created as it might affect the outcome. There is one known issue: https://github.com/owncloud/core/issues/25564, please check if it matches your scenario exactly.

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.