Core-workflow: Remove `needs backport` label for rejected PRs

Created on 12 Apr 2017  路  4Comments  路  Source: python/core-workflow

Hi all,

I'm wondering if we can remove the needs backport to X.Y label for PRs that were rejected (e.g. closed, but not merged).

Thanks :)

question

All 4 comments

Sure.

I assume this is because you want to look at the backport label to see if anything was forgotten to be backported?

Thanks. I cleaned up the labels from the closed PRs. I needed an easy way to identify which PRs legitimately need to be backported 馃槂

The labels are speculative for 4 reasons: 1) the patch may never be applied; 2) the patch may be applied 'too late' for a particular version (after it goes off 'bugfix' status, as should be the case soon for 3.5); 3) we may just decide that a particular patch should not be back-ported for particular stability reasons; and 4) backport may require real work that the first committer declines to do.

The labels should be redundant because of the Versions field on the tracker. So I agree that their best use here is to avoid having backports forgotten.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

brettcannon picture brettcannon  路  9Comments

ammaraskar picture ammaraskar  路  9Comments

isidentical picture isidentical  路  4Comments

Mariatta picture Mariatta  路  10Comments

brettcannon picture brettcannon  路  3Comments